Misc fixes (#212)

* Misc fixes * Add comment * Fix for cancelled panels
multiprocessio · Apr 6, 2022 · 59010dd · 59010dd
1 parent fe6b642
commit 59010dd
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 4 deletions.
diff --git a/ui/PageList.tsx b/ui/PageList.tsx
@@ -59,6 +59,10 @@ export function makeReevalPanel(
     // Important! Just needs to trigger a state reload.
     updatePanelInternal(panel);
 
+    if (panel.resultMeta.exception) {
+      return;
+    }
+
     // Re-run all dependent visual panels
     if (!VISUAL_PANELS.includes(panel.type)) {
       for (const dep of page.panels) {

diff --git a/ui/Panel.tsx b/ui/Panel.tsx
@@ -306,7 +306,14 @@ export function Panel({
   async function evalThis() {
     if (killable) {
       await killProcess();
-      setLoading(false);
+
+      // Only don't reeval if we think it's already not running.  //
+      // This allows the UI to kill any background running process that
+      // might have started on a different page or something like that.
+      if (loading) {
+        setLoading(false);
+        return;
+      }
     }
 
     setLoading(true);
@@ -416,7 +423,7 @@ export function Panel({
               </Button>
             </span>
 
-            <label className="ml-2 text-muted">
+            <label className="ml-2 text-muted" title={panel.id}>
               {PANEL_UI_DETAILS[panel.type].label}
             </label>
 

diff --git a/ui/PanelList.tsx b/ui/PanelList.tsx
@@ -139,7 +139,7 @@ export function PanelList({
         });
       }
 
-      updatePanel(next, panelIndex, true);
+      updatePanel(next, panelIndex + 1, true);
     }
 
     const offerToTable =

diff --git a/ui/app.tsx b/ui/app.tsx
@@ -165,7 +165,7 @@ export function App<T extends DefaultView = DefaultView>({
         >
           <div className={`app app--${MODE} app--${settings.theme}`}>
             {MODE_FEATURES.appHeader && <Header />}
-            <main className={'view-' + (urlState.view || 'editor')}>
+            <main className={'view view-' + (urlState.view || 'editor')}>
               {urlState.projectId && <Navigation pages={routes} />}
               {main}
             </main>

diff --git a/ui/components/CodeEditor.tsx b/ui/components/CodeEditor.tsx
@@ -84,7 +84,14 @@ export function CodeEditor({
       return;
     }
 
+    // Without this the clearSelection call below moves the cursor to the end of the textarea destroying in-action edits
+    if (editorNode.editor.container.contains(document.activeElement)) {
+      return;
+    }
+
     editorNode.editor.setValue(value);
+    // setValue() also highlights the inserted values so this gets rid
+    // of the highlight. Kind of a weird API really
     editorNode.editor.clearSelection();
   }, [value, editorNode]);
 

diff --git a/ui/style.css b/ui/style.css
@@ -78,6 +78,11 @@ a:hover {
   display: block;
 }
 
+.view {
+  /* Very important! Gives the main panel list it's overflow so it scrolls independent of the sidebar */
+  width: 100%;
+}
+
 .main-body {
   flex: 1;
   overflow-y: auto;