Skip to content

Commit

Permalink
Fix form trimming (#95)
Browse files Browse the repository at this point in the history
  • Loading branch information
eatonphil committed Nov 17, 2021
1 parent 6be0002 commit 1db0d8c
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 9 deletions.
4 changes: 2 additions & 2 deletions ui/components/Input.tsx
Expand Up @@ -72,8 +72,8 @@ export function Input({
);

function removeOuterWhitespaceOnFinish() {
if (typeof value === 'string') {
setLocalValue(value.trim());
if (typeof localValue === 'string') {
setLocalValue(localValue.trim());
}
}

Expand Down
20 changes: 13 additions & 7 deletions ui/connectors/GenericDetails.tsx
Expand Up @@ -14,15 +14,16 @@ export interface GenericDetailsProps {
}

export function GenericDetails(props: GenericDetailsProps) {
const { servers, connector, updateConnector } = props;
const { skipDatabase, ...passalong } = props;
const { servers, connector, updateConnector, skipDatabase } = props;

return (
<React.Fragment>
<Host {...passalong} />
{skipDatabase ? null : <Database {...passalong} connector={connector} />}
<Username {...passalong} connector={connector} />
<Password {...passalong} connector={connector} />
<Host connector={connector} updateConnector={updateConnector} />
{skipDatabase ? null : (
<Database connector={connector} updateConnector={updateConnector} />
)}
<Username connector={connector} updateConnector={updateConnector} />
<Password connector={connector} updateConnector={updateConnector} />
<ServerPicker
servers={servers}
serverId={connector.serverId}
Expand All @@ -36,5 +37,10 @@ export function GenericDetails(props: GenericDetailsProps) {
}

export const GenericNoDatabaseDetails = (props: GenericDetailsProps) => (
<GenericDetails {...props} skipDatabase />
<GenericDetails
connector={props.connector}
updateConnector={props.updateConnector}
servers={props.servers}
skipDatabase
/>
);

0 comments on commit 1db0d8c

Please sign in to comment.