feat: allocating inline IPLD multiformats #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeal
changed the title
|
We may also want to allocate uint8, uint16, and uint32 multiformats for when we need to do fixed length number encodings. |
|
bit of a can of worms here if we start adding all the possible types in the single byte range - various string encodings, float encodings, all the ints and their endianness forms; so maybe this should be done in the two-byte range so we can add whatever people want? |
|
I don't know what inline IPLD is used for. Is the idea to use it inside CIDs? I'm with @rvagg here. Those experimental things belong in the >=2 bytes range. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've talked about this informally for a while, I'd like to start experimenting with it but I want to make sure we get low numbers allocated to basic inline IPLD types.