Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps for encoding and decoding #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ben221199
Copy link

This pull request adds steps to tell in a basic way how to encode and decode multiaddrs.

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a maintainer of this repository. Thus feel free to ignore the below. I appreciate the help here and in the many other pull requests.

I am not sure how much value this pseudo code gives us. Would it not make more sense to point to one of the implementations, thus appointing that implementation as the reference implementation?

@ben221199
Copy link
Author

I understand your view about the pseudo-code. However, I think that it better to have some neutral pseudo-code instead of pointing developers coding in some language to an implementation in another language. I even think that the implementations in this GitHub organization shouldn't even be part of the specifications and just keep it only core level, but that is my point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants