Fix cell colors in location view #6246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
commented
May 13, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions
ios/MullvadVPN/View controllers/SelectLocation/LocationCell.swift line 137 at r1 (raw file):
backgroundView = UIView() backgroundView?.backgroundColor = UIColor.Cell.Background.normal
Opportunistic cleanup not really related to PR.
ios/MullvadVPN/View controllers/SelectLocation/LocationSectionHeaderView.swift line 69 at r1 (raw file):
actionButton.isHidden = isActionHidden actionButton.accessibilityIdentifier = nil actualConfiguration.primaryAction.flatMap { [weak self] action in
Opportunistic cleanup not related to PR.
buggmagnet
approved these changes
May 16, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions
buggmagnet
force-pushed
the
countrycustom-list-color-in-select-location-ios-677
branch
from
b8c6108
to
d382e99
Compare
buggmagnet
deleted the
countrycustom-list-color-in-select-location-ios-677
branch
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added custom lists we also added a title list item (All locations) which made the countries/cities/servers in the location view move down one step in the hierarchy. So we had to add a new color (Blue10%). This PR updates all related colors to their correct values.
This change is