Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ttcc back to its original location #6209

Closed
wants to merge 42 commits into from
Closed

Move ttcc back to its original location #6209

wants to merge 42 commits into from

Conversation

buggmagnet
Copy link
Contributor

@buggmagnet buggmagnet commented May 2, 2024 •
edited by faern

This PR does 2 things mostly

  • Rebase from a more recent version of main
  • Remove the iOS custom TTCC crate in favour of the original one.

This change is Reviewable

pinkisemils and others added 30 commits April 29, 2024 11:23
@pinkisemils @buggmagnet
Add FFI to talpid-tunnel-config-client
cf980c8
@buggmagnet
Remove debug statements
e10fece
@buggmagnet
Regroup switch cases together
87710df
@buggmagnet
Enable reading Quantum Resistance settings from SettingsReader
86e12c8
@acb-mv @buggmagnet
Add utility methods for mutating State's data, replacing switch stmts
6593cc9
@acb-mv @buggmagnet
Remove premature changes not related to this refactoring
64baed2
@acb-mv @buggmagnet
Remove commented dead code
2b1f0dc
@acb-mv @buggmagnet
Make State Equatable, move change checks to didSet &c
15698a2
@buggmagnet
Add a new actor state for key negotiation
eb8a951
@buggmagnet
Read settings to determine whether to exchange a PQ key
b528169
@buggmagnet
Try to reconnect when PQ key exchange fails
f92a81e
@buggmagnet
Remove dead code
5b7a204
@buggmagnet
Enable exchanging PQ keys from an unconnected state
7b2e5e6
@buggmagnet
Add safety checks at the FFI boundary
97946da
@buggmagnet
Remove unneeded dependencies
55f646b
@acb-mv @buggmagnet
Tidy code around key negotiation and cancellation token flow
ceecd50
@acb-mv @buggmagnet
Add "tidy" as an imperative verb
95979bc
@acb-mv @buggmagnet
Update git-commit-message-style to match main
f8e2696
@buggmagnet
Fix a typo
34bcefe
@buggmagnet
Remove unneeded framework reference
84c28b8
@buggmagnet
Rewrite the PQ cancellation token in a safer way
c742674
@buggmagnet
Fix rebase issues
e3b54dd
@buggmagnet
Add a method to receive the preshared key in the actor
6ba2959
@acb-mv @buggmagnet
Add preSharedKey to configurationBuilder
b85d480
@acb-mv @buggmagnet
Attempt at starting a tunnel with the PQ shared key
31d3e18
@buggmagnet
Hack the new private key as a global to prove PQ PSK works
7864765
@buggmagnet
Prototype a new actor to handle PQ PSK
c805115
@acb-mv @buggmagnet
Add the ephemeral private key to the negotiation data flow (Swift-sid…
07aaa66 
…e only; Rust needs work)
@acb-mv @buggmagnet
Pass the ephemeral key to postQuantumConnect
2af50f2
@acb-mv @buggmagnet
Modify (partially) Rust code to handle the ephemeral key as passed th…
71156e1 
…rough
@buggmagnet buggmagnet added the iOS Issues related to iOS label May 2, 2024
@buggmagnet buggmagnet self-assigned this May 2, 2024
@buggmagnet buggmagnet force-pushed the move-ttcc-back-to-its-original-location branch from 4955b22 to 9bef286 Compare May 2, 2024 12:46
dlon
dlon reviewed May 6, 2024
View reviewed changes
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 50 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

ios/MullvadPostQuantum/talpid-tunnel-config-client/Cargo.toml line 1 at r1 (raw file):

[package]

Should this crate be removed? (It's duplicated.)

@buggmagnet buggmagnet force-pushed the features/ios-post-quantum branch 7 times, most recently from 591aca8 to 1de5f57 Compare May 8, 2024 09:12
@buggmagnet buggmagnet force-pushed the features/ios-post-quantum branch 12 times, most recently from 27a5e2f to d39bfff Compare May 20, 2024 09:02
@buggmagnet buggmagnet closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlon dlon dlon left review comments

@acb-mv acb-mv acb-mv approved these changes

@pinkisemils pinkisemils Awaiting requested review from pinkisemils

Assignees

@buggmagnet buggmagnet

Labels
iOS Issues related to iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@buggmagnet @dlon @acb-mv @pinkisemils