Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit commit check to PRs #6168

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Apr 23, 2024

This PR aims to make sure the git commit check only runs on PRs as documented here: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request


This change is Reviewable

@albin-mullvad albin-mullvad self-assigned this Apr 23, 2024
@albin-mullvad albin-mullvad requested review from faern and removed request for faern April 23, 2024 08:56
Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)


.github/workflows/git-commit-message-style.yml line 4 at r1 (raw file):

name: Git - Check commit message style
on:
  pull_request:

This has the problem that it checks the PR description if it's wrapped at 72 characters. I don't know why it does this. It's really weird IMO! Github PR descriptions have no real reason to be word wrapped. See if you can disable this check or work around it maybe?

@albin-mullvad
Copy link
Collaborator Author

albin-mullvad commented Apr 23, 2024

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

.github/workflows/git-commit-message-style.yml line 4 at r1 (raw file):

name: Git - Check commit message style
on:
  pull_request:

This has the problem that it checks the PR description if it's wrapped at 72 characters. I don't know why it does this. It's really weird IMO! Github PR descriptions have no real reason to be word wrapped. See if you can disable this check or work around it maybe?

Yeah, thought of doing a quick fix but got really surprised 😆

@albin-mullvad albin-mullvad marked this pull request as draft April 23, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants