fix: #2960 type error

[JerryWu1234]

#2960

• I've read and followed the contributing guide on how to create great pull requests.
• I've updated the relevant documentation for any new or updated feature.
• I've linked relevant GitHub issue with "Closes #".
• I've added a visual demonstration in the form of a screenshot or video.

[JerryWu1234]

[JerryWu1234]

@Janpot
There is a slight conflict because you want to print the error message in the Toolpad CLI. It cannot concurrently ask the user whether they want to save the content because the error message has already been intercepted by the try-catch block in the backend.

If you want to achieve this goal, I suggest invoking the applyDomDiff after detecting the error. This way, we can ensure that the frontend has already received an error message

[JerryWu1234]

@Janpot please review

[Janpot]

Let's give users some context

Suggested change

	console.error(err.message);
	console.error(`Failed to save the dom: ${err.message}`);

[Janpot]

How do you feel about the following

• when we detect that prettier errored, we show a confirmation dialog "prettier failed with error X, do you want to save without formatting".
• this sets a ignoreFormattingErrors to the state
• add a force: boolean option to applyDomDiff which tries to prettify but ignores errors, we call it with:

  applyDomDiff(state.dom, { force: state.ignoreFormattingErrors })

[JerryWu1234]

let me try

[JerryWu1234]

when we detect that prettier errored, we show confirmation a dialog "prettier failed with error X, do you want to save without formatting".

how to display this dialog ? if a format error is detected, this dialog will be always displayed
is there a strategy for this dialog?

[JerryWu1234]

@Janpot

[Janpot]

if a format error is detected, this dialog will be always displayed
is there a strategy for this dialog?

If a user confirms the dialog, then ignoreFormattingErrors will get set in the state, and the next time applyDomDiff is called it will get a force: true value and shouldn't error on formatting errors.

[JerryWu1234]

How about the ignoreFormattingErrors gets false? we don't do anything?

[Janpot]

We don't leave that option open. You either confirm or fix your setup. i.e. We say:

Failed to save because of an error in your formatter:
{error message}
Click Ignore to save without formatting, or "Retry" to try again.