Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Apply 3 different fixes #5695

Merged
merged 1 commit into from Dec 1, 2016
Merged

[core] Apply 3 different fixes #5695

merged 1 commit into from Dec 1, 2016

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 30, 2016

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

I was trying to push some code into production with the master state.
I have come across those issues.

Fix #5697

- Prevent using style conflicting properties like border and border Button
facebook/react#6348
- Avoid using ES6 features that can't be transpiled like includes
- Remove dead style properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants