Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FocusTrap] update getTabbable function return type #42237

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

KalmarLorand
Copy link

Part of: #42231

FocusTrap component: Change the return type of the getTabbable function from ReadonlyArray<string> to ReadonlyArray<HTMLElement>.

@mui-bot
Copy link

mui-bot commented May 14, 2024

Netlify deploy preview

https://deploy-preview-42237--material-ui.netlify.app/

Bundle size report

Bundle size will be reported once CircleCI build #696722 finishes.

Generated by 🚫 dangerJS against cd77c9f

@mnajdova mnajdova added bug 🐛 Something doesn't work typescript component: FocusTrap The React component. labels May 15, 2024
@mnajdova
Copy link
Member

Hey @KalmarLorand thanks for taking a stab at this issue. When changing the types you need to run:

pnpm prototypes
pnpm docs:api

to ensure that the propTypes and the docs API are up to date. This will fix the CI failing checks.

@zannager zannager requested a review from mnajdova May 15, 2024 13:48
@KalmarLorand
Copy link
Author

Hey @KalmarLorand thanks for taking a stab at this issue. When changing the types you need to run:

pnpm prototypes
pnpm docs:api

to ensure that the propTypes and the docs API are up to date. This will fix the CI failing checks.

Hey, thanks for the heads-up. I've ran the commands but for some reason nothing no files were changed
No declaration for FocusTrapSlots Built API docs for /base-ui/react-focus-trap/components-api/#focus-trap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: FocusTrap The React component. typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants