[material-ui][Tooltip] Deprecate components and componentProps props for v6 #42107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewBundle size report |
zannager
added
component: tooltip
17 tasks
DiegoAndai
reviewed
May 3, 2024
There was a problem hiding this comment.
Hey @ChronicusUA! Thanks for working on this as well.
A very similar review as #42111, let's discuss the EOL problem on that PR.
| Use the [codemod](https://github.com/mui/material-ui/tree/HEAD/packages/mui-codemod#tooltip-props) below to migrate the code as described in the following sections: | ||
|
|
||
| ```bash | ||
| npx @mui/codemod@latest deprecations/tooltip-props <path> |
There was a problem hiding this comment.
Suggested change
| npx @mui/codemod@latest deprecations/tooltip-props <path> | |
| npx @mui/codemod@next deprecations/tooltip-props <path> |
There was a problem hiding this comment.
I can see that some docs for component have latest and others have next. For example Slider (example PR for the main issue) has latest. I will fix it for my PRs
|
|
||
| ### components | ||
|
|
||
| The Tooltip's `components` was deprecated in favor of `slots`: |
There was a problem hiding this comment.
Suggested change
| The Tooltip's `components` was deprecated in favor of `slots`: | |
| The Tooltip's `components` prop was deprecated in favor of `slots`: |
There was a problem hiding this comment.
That word is missing for other component docs in the file. I will update my changes only
|
|
||
| ### componentsProps | ||
|
|
||
| The Tooltip's `componentsProps` was deprecated in favor of `slotProps`: |
There was a problem hiding this comment.
Suggested change
| The Tooltip's `componentsProps` was deprecated in favor of `slotProps`: | |
| The Tooltip's `componentsProps` prop was deprecated in favor of `slotProps`: |
| import Tooltip from '@mui/material/Tooltip'; | ||
|
|
||
| <Tooltip | ||
| components={{ Arrow: ComponentsArrow }} |
There was a problem hiding this comment.
Let's cover all slots (arrow, popper, tooltip, transition) on the test cases
github-actions
bot
added
the
PR: out-of-date
1 task
ChronicusUA
force-pushed
the
feat/41279-Update-Tooltip
branch
from
4d12598
to
0cbf808
Compare
github-actions
bot
removed
the
PR: out-of-date
|
PR is updated |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
DiegoAndai
reviewed
May 24, 2024
packages/mui-codemod/src/deprecations/tooltip-props/tooltip-props.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Diego Andai <diego@mui.com>
DiegoAndai
approved these changes
May 24, 2024
|
Thanks @ChronicusUA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41279
Deprecate components and componentsProps props for Tooltip component