Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Fix SelectDisplayProps className concat #23211

Merged
merged 2 commits into from Oct 22, 2020
Merged

[Select] Fix SelectDisplayProps className concat #23211

merged 2 commits into from Oct 22, 2020

Conversation

reedanders
Copy link
Contributor

I believe this should close #23201. Let me know if you have any other suggestions.

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 22, 2020 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 945d672

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! labels Oct 22, 2020
@oliviertassinari oliviertassinari changed the title Use SelectDisplayProps in classes after spread [Select] Fix SelectDisplayProps className concat Oct 22, 2020
@github-actions github-actions bot mentioned this pull request Oct 22, 2020
Closed
@oliviertassinari oliviertassinari merged commit e950315 into mui:next Oct 22, 2020
@oliviertassinari
Copy link
Member

@reedanders It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@reedanders reedanders deleted the issue-23201 branch October 22, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] Style is broken when adding a className in the SelectDisplayProps
3 participants
@reedanders @mui-pr-bot @oliviertassinari