Provide isScrollbarVisible for table #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like this PR is not compatible with react@0.14. See #1030 |
|
How should a component give feedback to the outside in react 0.14? Just dump it in the props so a parent can read it out? |
|
Turn out we can according to this passage of the post |
|
Ah, good :) |
shaurya947
added a commit
that referenced
this pull request
Sep 29, 2015
Provide isScrollbarVisible for table
| @@ -148,6 +148,13 @@ let Table = React.createClass({ | |||
| ); | |||
| }, | |||
|
|
|||
| isScrollbarVisible() { | |||
| const tableDivHeight = React.findDOMNode(this.refs.tableDiv).clientHeight; | |||
| const tableBodyHeight = React.findDOMNode(this.refs.tableBody).clientHeight; | |||
There was a problem hiding this comment.
The findDOMNode call would need to be changed whenever we move to react 0.14
This was referenced Sep 26, 2021
zannager
added
the
component: table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when the
Tablehas enough elements in the body, it will gain a scrollbar.Since this scrollbar is applied to the main rows, the header actually has no clue about it. In some cases, this might break positioning of header elements (because the main rows suddenly get a little bit smaller width due to a visible scrollbar).
By providing a
isScrollbarVisible()onTablethe caller can determine if a scrollbar is visible, and take it into account in his styles to possibly offset this.