Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip] Add some docs for disabled elements #12265

Merged

Conversation

kamranayub
Copy link
Contributor

@kamranayub kamranayub commented Jul 24, 2018

Closes #11601

Some docs around the issue of disabled elements to bring it to people's attention if reviewing the Tooltip demos and save them some headaches.

The bootstrap docs mention pointer-events but I haven't seen a need for that yet, not sure: https://getbootstrap.com/docs/4.1/components/popovers/#disabled-elements

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: tooltip This is the name of the generic UI component, not the React module! labels Jul 24, 2018
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamranayub Nice job!

@oliviertassinari
Copy link
Member

@kamranayub It's an awesome first pull request on Material-UI 👌🏻. Thank you for giving it a shot!

@oliviertassinari oliviertassinari merged commit 4f55f78 into mui:master Jul 24, 2018
@oliviertassinari
Copy link
Member

The bootstrap docs mention pointer-events but I haven't seen a need for that yet

I have seen them doing it too. I'm fine with only having the hover listener working 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tooltip This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants