Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add Menu example for Composition of Popover and MenuList #10149

Closed
wants to merge 1 commit into from

Conversation

caub
Copy link
Contributor

@caub caub commented Feb 3, 2018

to clear a bit confusion in #7956

(I'd like to add react-router in the examples, either in the same demos/menus/MenuListComposition file or somewhere else (guides, examples?)

Can refer to #10145 for integration with react-router

I'll try to improve the Demo component maybe, to pick only the needed dependecies for codesandbox #10150

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 3, 2018

@caub Thank you for looking into clearing the confusion of #7956. However, I don't think that it's the right place to do it. This new demo isn't discoverable. A documentation section like https://material-ui.com/demos/buttons/#third-party-routing-library would be much more effective. For now on, let's push #10128 forward.

@caub
Copy link
Contributor Author

caub commented Feb 3, 2018

no problemo , I just propose:)

@zannager zannager added the docs Improvements or additions to the documentation label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants