refactor: Service Wiring / Concurrency pt 1 #2202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai canceled.
|
dave-gray101
changed the title
backend services Signed-off-by: Dave Lee <dave@gray101.com>
dave-gray101
force-pushed
the
rf-service-wiring-1a
branch
from
1e50581
to
8c542fc
Compare
github-actions
bot
added
kind/documentation
dave-gray101
added
area/golang
area/api
area/backends
and removed
kind/documentation
Signed-off-by: Dave Lee <dave@gray101.com>
…r future sanity Signed-off-by: Dave Lee <dave@gray101.com>
copy paste error Signed-off-by: Dave Lee <dave@gray101.com>
dave-gray101
force-pushed
the
rf-service-wiring-1a
branch
from
eb81bcc
to
8419b10
Compare
…t model' to the process. not currently used in this pr, but IS used in the next one for image generation. Backdating it to pr1 for merge reasons Signed-off-by: Dave Lee <dave@gray101.com>
Signed-off-by: Dave Lee <dave@gray101.com>
Signed-off-by: Dave Lee <dave@gray101.com>
…I into rf-service-wiring-1a
Signed-off-by: Dave Lee <dave@gray101.com>
dave-gray101
force-pushed
the
rf-service-wiring-1a
branch
from
807da80
to
b43ca24
Compare
github-actions
bot
added
kind/documentation
dave-gray101
changed the title
dave-gray101
force-pushed
the
rf-service-wiring-1a
branch
from
b43ca24
to
807da80
Compare
dave-gray101
changed the title
auto-merge was automatically disabled
May 23, 2024 22:13
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the start of transitioning our core services to the
core/application.go\core/startupmodel.In order to keep things reviewable, this PR will have a limited scope - rather than moving everything at once, my goal is to select services that are covered by existing tests for the detection of regressions. Therefore, this PR contains the following components:
core/startuppkg/concurrency- basicJobResultstructure