Sprint 2 Release #146
Merged
Sprint 2 Release #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download points to main instead of develop now that there is something to download in main.
Readme updates
- added build directories to gitignore - modified project name in setup.py
Build System up and Running Rename and updating imports looks good
Minor test updates. Most passing as is.
- Moved parser and lexer into their own files - updated gitignore for arch venv directories
- Lexer: reads a command from user input, splits it into parseable chunks - Parser: reads the parseable chunks from the lexer, turning them into a command and arguments - method check_args is floating so that it can be used wherever needed (namely controller save and load) This passed all tests before uploading
These tests no longer create a controller, and as such can no longer test controller methods. This will be fixed when everything is rewritten in pytest
Method and field
May need to do something with the old param list to make it work as it currently is, but that should be okay.
- Parser now handles save, load, and quit again - Parser is no longer its own object - Parser now takes an instance of the controller which it uses to generate instance-specific command objects - Lexer is now back in controller - Lexer is being used for all views, and has been renamed accordingly
Gui save/load/exit
Added rename functionality
Building tests
function due to str() type field/param)
Cleanup main.py and update readme
smschwartz
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.