Prevent override global URL when environment is not client #667
+3
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Musacoli
approved these changes
Aug 22, 2020
|
@muaz-khan Can you get this merged? Would be really helpful. |
|
@muaz-khan, can this please be addressed? |
|
Please merge. I just ran into this issue as well. |
|
Hey please fix this I just ran into this issue as well. |
|
To get RecordRTC and StereoAudioRecorder working with NextJS, I had to apply these the changes in this PR using patch-package. Would be great to get these merged into master |
|
@muaz-khan can you merge this? |
|
Ran into this issue too with NExtJS. Is this package no longer maintained? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will temporarily fix issue on #666
URL namespace is always available in server side (Nodejs) as well as client-side.
In client, it will resolve to window.URL
In case it's undefined. The fallback code can do its job.