New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated deprecated MediaStream.stop() in Audio recorder example #560

Open

moosthuizen42 wants to merge 2 commits into muaz-khan:master from moosthuizen42:master

moosthuizen42 commented Sep 19, 2019

Replaced microphone.stop() with microphone.getTracks().forEach( t => t.stop());

MediaStream.stop() is deprecated according to https://developer.mozilla.org/en-US/docs/Web/API/Media_Streams_API.

moosthuizen42 added 2 commits

September 19, 2019 14:52


          Updated depcrecated MediaStream.stop()

2e6df99

I experienced the same problem described in: 
https://stackoverflow.com/questions/34966809/stop-kill-webrtc-media-stream.

According to https://developer.mozilla.org/en-US/docs/Web/API/Media_Streams_API, MediaStream.stop() is deprecated.

This commit changes .stop() to .getTracks().forEach( t => t.stop());


          Merge pull request #1 from moosthuizen42/moosthuizen42-audio-demo-update

9c0ccf5

Updated depcrecated MediaStream.stop()

thijstriemstra approved these changes

View reviewed changes

Contributor

thijstriemstra commented Sep 19, 2019

ping @muaz-khan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment