#615, @thijstriemstra plz test on firefox, still using TRY-CATCH though

https://www.webrtc-experiment.com/RecordRTC/simple-demos/WebAssemblyRecorder.html @thijstriemstra Should we revert PR #615?
muaz-khan · May 17, 2020 · 1fd3e03 · 1fd3e03
1 parent 56af2e4
commit 1fd3e03
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 21 deletions.
diff --git a/README.md b/README.md
@@ -74,8 +74,8 @@ navigator.mediaDevices.getUserMedia({
 <!-- recommended -->
 <script src="https://www.WebRTC-Experiment.com/RecordRTC.js"></script>
 
-<!-- use 5.6.0 or any other version on cdnjs -->
-<script src="https://cdnjs.cloudflare.com/ajax/libs/RecordRTC/5.6.0/RecordRTC.js"></script>
+<!-- use 5.6.1 or any other version on cdnjs -->
+<script src="https://cdnjs.cloudflare.com/ajax/libs/RecordRTC/5.6.1/RecordRTC.js"></script>
 
 <!-- NPM i.e. "npm install recordrtc" -->
 <script src="node_modules/recordrtc/RecordRTC.js"></script>

diff --git a/RecordRTC.js b/RecordRTC.js
@@ -1,9 +1,9 @@
 'use strict';
 
-// Last time updated: 2020-05-16 3:19:43 PM UTC
+// Last time updated: 2020-05-17 5:04:38 PM UTC
 
 // ________________
-// RecordRTC v5.6.0
+// RecordRTC v5.6.1
 
 // Open-Sourced: https://github.com/muaz-khan/RecordRTC
 
@@ -781,7 +781,7 @@ function RecordRTC(mediaStream, config) {
          * @example
          * alert(recorder.version);
          */
-        version: '5.6.0'
+        version: '5.6.1'
     };
 
     if (!this) {
@@ -799,7 +799,7 @@ function RecordRTC(mediaStream, config) {
     return returnObject;
 }
 
-RecordRTC.version = '5.6.0';
+RecordRTC.version = '5.6.1';
 
 if (typeof module !== 'undefined' /* && !!module.exports*/ ) {
     module.exports = RecordRTC;
@@ -5924,7 +5924,7 @@ function RecordRTCPromisesHandler(mediaStream, options) {
      * @example
      * alert(recorder.version);
      */
-    this.version = '5.6.0';
+    this.version = '5.6.1';
 }
 
 if (typeof RecordRTC !== 'undefined') {
@@ -6005,9 +6005,13 @@ function WebAssemblyRecorder(stream, config) {
                         }
 
                         ctx.drawImage(video, 0, 0);
-                        controller.enqueue(
-                            ctx.getImageData(0, 0, config.width, config.height)
-                        );
+                        if (controller._controlledReadableStream.state !== 'closed') {
+                            try {
+                                controller.enqueue(
+                                    ctx.getImageData(0, 0, config.width, config.height)
+                                );
+                            } catch (e) {}
+                        }
                     }, frameTimeout);
                 };
                 video.play();

diff --git a/RecordRTC.min.js b/RecordRTC.min.js
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "recordrtc",
-  "version": "5.6.0",
+  "version": "5.6.1",
   "authors": [
         {
             "name": "Muaz Khan",

diff --git a/dev/WebAssemblyRecorder.js b/dev/WebAssemblyRecorder.js
@@ -72,9 +72,13 @@ function WebAssemblyRecorder(stream, config) {
                         }
 
                         ctx.drawImage(video, 0, 0);
-                        controller.enqueue(
-                            ctx.getImageData(0, 0, config.width, config.height)
-                        );
+                        if (controller._controlledReadableStream.state !== 'closed') {
+                            try {
+                                controller.enqueue(
+                                    ctx.getImageData(0, 0, config.width, config.height)
+                                );
+                            } catch (e) {}
+                        }
                     }, frameTimeout);
                 };
                 video.play();

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "recordrtc",
   "preferGlobal": false,
-  "version": "5.6.0",
+  "version": "5.6.1",
   "author": {
     "name": "Muaz Khan",
     "email": "muazkh@gmail.com",

diff --git a/simple-demos/WebAssemblyRecorder.html b/simple-demos/WebAssemblyRecorder.html
@@ -10,7 +10,7 @@
 }
 </style>
 
-<h1>WebAssembly Recorder using RecordRTC</h1>
+<h1>WebAssembly Recorder using RecordRTC <span id="version"></span></h1>
 <button id="start">Start Recording</button>
 <button id="stop" disabled>Stop Recording</button>
 <br><br>
@@ -22,6 +22,8 @@ <h1>WebAssembly Recorder using RecordRTC</h1>
 <script src="/RecordRTC.js"></script>
 
 <script>
+document.getElementById('version').innerHTML = RecordRTC.version;
+
 var recorder;
 
 document.getElementById('start').onclick = function() {