drm/panel: s6e8aa5x01-ams497hy01 Samsung J5 backlight support #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Grimler91 Do you mind taking a look at these changes? |
The code was shamelessly stolen from ams520kt01,seems to work the same way. The data was mined from downstream. Signed-off-by: Christoph Rudorff <chris@rudorff.com>
chr-chr
force-pushed
the
J5-hacking.backlight
branch
from
d038a7f
to
cd64d35
Compare
|
f this ... I donate a space ... |
|
Not J5X, but I would like to cc @B83C |
? |
|
Oo, found some bug that shall be fixed ;) |
added 2 commits
October 27, 2023 18:05
code cleanup. Signed-off-by: Christoph Rudorff <chris@rudorff.com>
backlight_device_register deprecated Signed-off-by: Christoph Rudorff <chris@rudorff.com>
|
code cleanup. @B83C: I guess the ams520kt01 can use this aswell. Whats left? Actually one brightness cmd takes up to 400ms and when juggling a brightness slider I occasional get:
but that did not hurt so far. @B83C: I'd like some enlightenment on the Temp1? / Temp2? cmds ... do we need them?! |
M0Rf30
pushed a commit
to msm8953-mainline/linux
that referenced
this pull request
Apr 1, 2024
[ Upstream commit 205c503 ] With lockdep enabled, calls to the connect function from cfg802.11 layer lead to the following warning: ============================= WARNING: suspicious RCU usage 6.7.0-rc1-wt+ msm8916-mainline#333 Not tainted ----------------------------- drivers/net/wireless/microchip/wilc1000/hif.c:386 suspicious rcu_dereference_check() usage! [...] stack backtrace: CPU: 0 PID: 100 Comm: wpa_supplicant Not tainted 6.7.0-rc1-wt+ msm8916-mainline#333 Hardware name: Atmel SAMA5 unwind_backtrace from show_stack+0x18/0x1c show_stack from dump_stack_lvl+0x34/0x48 dump_stack_lvl from wilc_parse_join_bss_param+0x7dc/0x7f4 wilc_parse_join_bss_param from connect+0x2c4/0x648 connect from cfg80211_connect+0x30c/0xb74 cfg80211_connect from nl80211_connect+0x860/0xa94 nl80211_connect from genl_rcv_msg+0x3fc/0x59c genl_rcv_msg from netlink_rcv_skb+0xd0/0x1f8 netlink_rcv_skb from genl_rcv+0x2c/0x3c genl_rcv from netlink_unicast+0x3b0/0x550 netlink_unicast from netlink_sendmsg+0x368/0x688 netlink_sendmsg from ____sys_sendmsg+0x190/0x430 ____sys_sendmsg from ___sys_sendmsg+0x110/0x158 ___sys_sendmsg from sys_sendmsg+0xe8/0x150 sys_sendmsg from ret_fast_syscall+0x0/0x1c This warning is emitted because in the connect path, when trying to parse target BSS parameters, we dereference a RCU pointer whithout being in RCU critical section. Fix RCU dereference usage by moving it to a RCU read critical section. To avoid wrapping the whole wilc_parse_join_bss_param under the critical section, just use the critical section to copy ies data Fixes: c460495 ("staging: wilc1000: fix incorrent type in initializer") Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://msgid.link/20240105075733.36331-3-alexis.lothore@bootlin.com Signed-off-by: Sasha Levin <sashal@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was shamelessly stolen from ams520kt01, seems to work the same way.
The data was mined from downstream.
Tested, works for me.