arm64: dts: qcom: msm8916-lenovo-phab: add device #289

k1gen · 2023-02-23T18:58:00Z

Lenovo PHAB (PB1-750M) is a phablet using the
MSM8916 SoC released in late 2015.

Add a device tree with initial support for:

GPIO keys
Display & touchscreen
pm8916-vibrator
SDHCI (internal and external storage)
USB Device Mode
BMS & charging
UART (not tested)
WCNSS (WiFi/BT)
Modem (LTE works, calls & SMS not tested)
Regulators
Sound (WIP)
Accelerometer (WIP)

Signed-off-by: Oleksandr Knyshuk kigen745@gmail.com

Lenovo PHAB (PB1-750M) is a phablet using the MSM8916 SoC released in late 2015. Add a device tree for with initial support for: - GPIO keys - pm8916-vibrator - SDHCI (internal and external storage) - USB Device Mode - Charging - UART (not tested) - WCNSS (WiFi/BT) - Modem (LTE works, calls & SMS not tested) - Regulators - Sound (WIP) - Accelerometer (WIP) Signed-off-by: Oleksandr Knyshuk <kigen745@gmail.com>

Signed-off-by: Oleksandr Knyshuk <kigen745@gmail.com>

Add jdi_1080p display panel with pwm and backlight and FT5336 touchscreen with according pinctrls Signed-off-by: Oleksandr Knyshuk <kigen745@gmail.com>

…r-generator X-Code-Generator: msm8916-mainline/linux-panel-drivers@22b5266 Signed-off-by: lmdpdg <lmdpdg@localhost>

arch/arm64/boot/dts/qcom/msm8916-lenovo-phab.dts

wonderfulShrineMaidenOfParadise · 2023-02-23T19:31:40Z

arch/arm64/boot/dts/qcom/msm8916-lenovo-phab.dts

+
+&pm8916_bms {
+	monitored-battery = <&battery>;
+	//power-supplies = <&charger>;


It doesn't seem to be used or required.

It causes kernel panic, though it is the right way to use bms and charger together

wonderfulShrineMaidenOfParadise · 2023-02-23T19:35:47Z

arch/arm64/boot/dts/qcom/msm8916-lenovo-phab.dts

+	};
+};
+
+&blsp_i2c5 {


Unlike display panels, touchscreen can be upstreamed with the driver in Torvald's tree, so you might want to split it from the display panel commit.

is there an easy way to do it?

Not known yet, I assume. You need to do this during git rebase.

Do what, delete anyway?

Delete touchscreen parts, and commit with message blah blah

Revert commit, and reword the revert with message arm64: dts: qcom: msm8916-lenovo-phab: add touchscreen

Squash/fixup blah blah, and reword

You can probably reset the commit during the rebase, then split into two with git add --patch to only add some hunks (not sure if it would be split nicely though) and then squash the resulting touchscreen commit into the first one using another interactive rebase. Otherwise can probably interactive rebase -> edit first commit to add the TS and then fix the merge conflict when this commit applies.

wonderfulShrineMaidenOfParadise · 2023-02-23T19:45:42Z

drivers/gpu/drm/panel/msm8916-generated/panel-lenovo-phab-jdi_1080p.c

+}
+
+static const struct of_device_id jdi_of_match[] = {
+	{ .compatible = "lenovo,phab-jdi_1080p" }, // FIXME


Suggested change

{ .compatible = "lenovo,phab-jdi_1080p" }, // FIXME

{ .compatible = "lenovo,phab-jdi-1080p" }, // FIXME

or

Suggested change

{ .compatible = "lenovo,phab-jdi_1080p" }, // FIXME

{ .compatible = "lenovo,phab-jdi" }, // FIXME

You also need to fix it in msm8916-mainline/linux-panel-drivers#28 and generate the driver again.

can I use phab-panel?

Only when you have defined lenovo,phab-panel in lk2nd and it selects from multiple panels.
msm8916-mainline/lk2nd@933fbc3

Anyway here is the naming rule, <vendor>,[device-]<panel_name>.

<vendor>,[device-]<panel_name>.

I see panel_name, not panel-name

Basically it's meant to be dashes instead of underscores for compatible entries, if you know what I mean.

arch/arm64/boot/dts/qcom/msm8916-lenovo-phab.dts

Signed-off-by: Oleksandr Knyshuk <kigen745@gmail.com>

wonderfulShrineMaidenOfParadise · 2023-02-23T20:10:36Z

arch/arm64/boot/dts/qcom/msm8916-lenovo-phab.dts

+	smb_int_default: smb-int-default-state {
+		pins = "gpio62";
+		function = "gpio";
+


Suggested change

wonderfulShrineMaidenOfParadise · 2023-02-23T20:15:08Z

drivers/gpu/drm/panel/msm8916-generated/panel-lenovo-phab-jdi_1080p.c

+}
+
+static const struct of_device_id jdi_of_match[] = {
+	{ .compatible = "lenovo,phab-jdi_1080p" }, // FIXME


Only when you have defined lenovo,phab-panel in lk2nd and it selects from multiple panels.
msm8916-mainline/lk2nd@933fbc3

Anyway here is the naming rule, <vendor>,[device-]<panel_name>.

wonderfulShrineMaidenOfParadise · 2023-02-23T20:16:07Z

arch/arm64/boot/dts/qcom/msm8916-lenovo-phab.dts

+	};
+};
+
+&blsp_i2c5 {


Not known yet, I assume. You need to do this during git rebase.

TravMurav · 2023-02-24T09:47:59Z

arch/arm64/boot/dts/qcom/Makefile

@@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-asus-z010d.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-gplus-fl8005a.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-huawei-g7.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-huawei-y635.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-lenovo-phab.dtb


Commit message: Please drop "not tested" :)

(you can do a reword with interactive rebase fyi)

TravMurav · 2023-02-24T09:54:00Z

arch/arm64/boot/dts/qcom/msm8916-lenovo-phab.dts

+		summit,enable-usb-charging;
+		summit,enable-mains-charging;


I'm not sure if you actually need both here... is "mains" required? and/or is there an example that uses mains that you have took this from? (I'd expect "mains" to mean "mains power" aka 220v or a barrel jack)

TravMurav · 2023-02-24T10:01:26Z

arch/arm64/boot/dts/qcom/msm8916-lenovo-phab.dts

+	};
+};
+
+&blsp_i2c5 {


You can probably reset the commit during the rebase, then split into two with git add --patch to only add some hunks (not sure if it would be split nicely though) and then squash the resulting touchscreen commit into the first one using another interactive rebase. Otherwise can probably interactive rebase -> edit first commit to add the TS and then fix the merge conflict when this commit applies.

TravMurav · 2023-02-24T10:06:12Z

arch/arm64/boot/dts/qcom/msm8916-lenovo-phab.dts

+	qcom,platform-enable-gpio = <&msmgpio 109 GPIO_ACTIVE_HIGH>;
+	qcom,platform-reset-gpio = <&msmgpio 25 GPIO_ACTIVE_HIGH>;


I don't think the dsi port schema has any gpios...

https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml#L100

wonderfulShrineMaidenOfParadise · 2023-04-25T09:25:49Z

arch/arm64/boot/dts/qcom/msm8916-lenovo-phab.dts

+&pronto {
+	status = "okay";
+
+	iris {
+		compatible = "qcom,wcn3660b";
+	};
+};


A note about new changes since 6.3+: 3244442

k1gen added 3 commits February 23, 2023 20:10

arm64: dts: qcom: msm8916-lenovo-phab: add BMS

b96b42d

Signed-off-by: Oleksandr Knyshuk <kigen745@gmail.com>

arm64: dts: qcom: msm8916-lenovo-phab: add display & touchscreen

7d15c29

Add jdi_1080p display panel with pwm and backlight and FT5336 touchscreen with according pinctrls Signed-off-by: Oleksandr Knyshuk <kigen745@gmail.com>

k1gen force-pushed the lenovo-phab branch from 8bf794d to 7d15c29 Compare February 23, 2023 19:04

squash! MSM8916: drm/panel: Generate using linux-mdss-dsi-panel-drive…

f225958

…r-generator X-Code-Generator: msm8916-mainline/linux-panel-drivers@22b5266 Signed-off-by: lmdpdg <lmdpdg@localhost>

wonderfulShrineMaidenOfParadise suggested changes Feb 23, 2023

View reviewed changes

arm64: dts: qcom: msm8916-lenovo-phab: implement suggestions

140d470

Signed-off-by: Oleksandr Knyshuk <kigen745@gmail.com>

wonderfulShrineMaidenOfParadise suggested changes Feb 23, 2023

View reviewed changes

TravMurav reviewed Feb 24, 2023

View reviewed changes

stephan-gh marked this pull request as draft April 7, 2023 18:42

wonderfulShrineMaidenOfParadise reviewed Apr 25, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

arm64: dts: qcom: msm8916-lenovo-phab: add device #289

arm64: dts: qcom: msm8916-lenovo-phab: add device #289

k1gen commented Feb 23, 2023

wonderfulShrineMaidenOfParadise Feb 23, 2023

k1gen Feb 23, 2023

wonderfulShrineMaidenOfParadise Feb 23, 2023

k1gen Feb 23, 2023

wonderfulShrineMaidenOfParadise Feb 23, 2023

k1gen Feb 23, 2023

wonderfulShrineMaidenOfParadise Feb 24, 2023

TravMurav Feb 24, 2023

wonderfulShrineMaidenOfParadise Feb 23, 2023 •

edited

k1gen Feb 23, 2023

wonderfulShrineMaidenOfParadise Feb 23, 2023

k1gen Feb 23, 2023

wonderfulShrineMaidenOfParadise Feb 24, 2023

wonderfulShrineMaidenOfParadise Feb 23, 2023

wonderfulShrineMaidenOfParadise Feb 23, 2023

wonderfulShrineMaidenOfParadise Feb 23, 2023

TravMurav Feb 24, 2023

TravMurav Feb 24, 2023

TravMurav Feb 24, 2023

TravMurav Feb 24, 2023

wonderfulShrineMaidenOfParadise Apr 25, 2023

	{ .compatible = "lenovo,phab-jdi_1080p" }, // FIXME
	{ .compatible = "lenovo,phab-jdi-1080p" }, // FIXME

	{ .compatible = "lenovo,phab-jdi_1080p" }, // FIXME
	{ .compatible = "lenovo,phab-jdi" }, // FIXME

		qcom,platform-enable-gpio = <&msmgpio 109 GPIO_ACTIVE_HIGH>;
		qcom,platform-reset-gpio = <&msmgpio 25 GPIO_ACTIVE_HIGH>;

arm64: dts: qcom: msm8916-lenovo-phab: add device #289

Are you sure you want to change the base?

arm64: dts: qcom: msm8916-lenovo-phab: add device #289

Conversation

k1gen commented Feb 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wonderfulShrineMaidenOfParadise Feb 23, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wonderfulShrineMaidenOfParadise Feb 23, 2023 •

edited