Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device tree for ASUS ZenPad 8.0 #285

Draft
wants to merge 3 commits into
base: msm8916/6.2-rc5
Choose a base branch
from

Conversation

vm03
Copy link

@vm03 vm03 commented Feb 4, 2023

No description provided.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are suggested. Please have a look.

arch/arm64/boot/dts/qcom/msm8916-asus-p024.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-asus-p024.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-asus-p024.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-asus-p024.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-asus-p024.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-asus-p024.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-asus-p024.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-asus-p024.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-asus-p024.dts Outdated Show resolved Hide resolved
@wonderfulShrineMaidenOfParadise

Consider joining #msm8916:postmarketos.org for discussions.

@wonderfulShrineMaidenOfParadise
Copy link

Looks much better. There are something to do about the commit messages:

  • Signoff. See the logs
  • Add proper commit messages. For example, b3a6b08

Just a note. It's not clear whether we should apply the following changes:
- https://lore.kernel.org/lkml/20230109110107.3016323-2-nikita@trvn.ru/
- https://lore.kernel.org/lkml/20230109110107.3016323-3-nikita@trvn.ru/
- https://lore.kernel.org/lkml/20230109110107.3016323-4-nikita@trvn.ru/

@wonderfulShrineMaidenOfParadise

The Signed-off-by tag is invalid. You have to use full name. For example:
Signed-off-by: Random J Developer <random@developer.example.org>

Ref: https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

@vm03
Copy link
Author

vm03 commented Feb 9, 2023

@wonderfulShrineMaidenOfParadise can't understand what not good in signoff now... :(

@wonderfulShrineMaidenOfParadise

@wonderfulShrineMaidenOfParadise can't understand what not good in signoff now... :(

The current one is valid and looks good.

arm64: dts: qcom: Add device tree for ASUS ZenPad 8.0

ASUS ZenPad 8.0 is a tablet using the MSM8916 SoC.

Add device tree with initial support for:

  • ...
  • Vibrator

Did you add it? I don't see any vibrator in the device tree.

@vm03
Copy link
Author

vm03 commented Feb 9, 2023

@wonderfulShrineMaidenOfParadise can't understand what not good in signoff now... :(

The current one is valid and looks good.

arm64: dts: qcom: Add device tree for ASUS ZenPad 8.0
ASUS ZenPad 8.0 is a tablet using the MSM8916 SoC.
Add device tree with initial support for:

  • ...
  • Vibrator

Did you add it? I don't see any vibrator in the device tree.

No. Vibration at poweron misled me.

ASUS ZenPad 8.0 is a tablet using the MSM8916 SoC.

Add device tree with initial support for:

 - SDHCI (internal and external storage)
 - USB Device Mode
 - UART
 - Regulators
 - WiFi/BT
 - Volume buttons

This device tree is based on downstream device tree from ASUS.

Signed-off-by: Vasiliy Borisov <vasy@vasy.ru>
This device has battery and smb345 charger ic.
Add support for it.

Signed-off-by: Vasiliy Borisov <vasy@vasy.ru>
Add support for Modem and Sound in ASUS ZenPad 8.0.

Signed-off-by: Vasiliy Borisov <vasy@vasy.ru>
regulator-min-microvolt = <2950000>;
regulator-max-microvolt = <2950000>;

gpio = <&msmgpio 87 GPIO_ACTIVE_HIGH>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, have you tested if SD card is working? It looks like you copied this from z00l (which is fine), but the downstream device tree I'm looking at seems to specify 119.

https://github.com/msm8916-mainline/linux-downstream/blob/asus-p024/arch/arm/boot/dts/qcom/msm8916-mtp-Z380KL.dts#L236

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, untested. :( I will look it.

@stephan-gh stephan-gh marked this pull request as draft April 11, 2023 07:40
Comment on lines +114 to +116
&pronto {
status = "okay";
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note about new changes since 6.3+: 3244442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants