arm64: dts: qcom: msm8916-samsung-j5-common: Upstreaming #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderfulShrineMaidenOfParadise
force-pushed
the
j5
branch
2 times, most recently
from
a154b79
to
90b1f97
Compare
stephan-gh
reviewed
Nov 19, 2022
|
|
||
| led-max-microamp = <300000>; | ||
| flash-max-microamp = <1500000>; | ||
| flash-max-timeout-us = <1835000>; |
There was a problem hiding this comment.
Curious mostly, where are these values coming from? Or are they just made up?
There was a problem hiding this comment.
mainl1ne@20c0f7c#diff-92c2357e6d8e3028d5884f443969796f7d690bd991dc913f8f1fdd23575c14b2R219-R221
They are copied values and I am not sure what they do.
There was a problem hiding this comment.
Maybe @nergzd723 can share where they are coming from. I failed to find them in a obvious way downstream.
There was a problem hiding this comment.
I believe downstream KTD2692_MOVIE_CURRENT4 and KTD2692_FLASH_CURRENT16 would match those values. I don't remember how I converted it to uA, exactly.
There was a problem hiding this comment.
I still don't really understand it, but I guess I'm fine with it as long as you make sure that it works properly :)
wonderfulShrineMaidenOfParadise
force-pushed
the
j5
branch
from
90b1f97
to
aed7cf5
Compare
wonderfulShrineMaidenOfParadise
changed the base branch from
msm8916/6.1-rc5
to
msm8916/6.1-rc6
wonderfulShrineMaidenOfParadise
force-pushed
the
j5
branch
from
aed7cf5
to
50db6ab
Compare
stephan-gh
reviewed
Nov 24, 2022
wonderfulShrineMaidenOfParadise
force-pushed
the
j5
branch
2 times, most recently
from
a91a84b
to
e0f0936
Compare
stephan-gh
changed the title
wonderfulShrineMaidenOfParadise
changed the base branch from
msm8916/6.1-rc6
to
msm8916/6.1-rc7
wonderfulShrineMaidenOfParadise
force-pushed
the
j5
branch
from
e0f0936
to
7e5ac50
Compare
wonderfulShrineMaidenOfParadise
force-pushed
the
j5
branch
from
7e5ac50
to
b7bbeb3
Compare
wonderfulShrineMaidenOfParadise
changed the base branch from
msm8916/6.1-rc7
to
msm8916/6.1-rc8
wonderfulShrineMaidenOfParadise
changed the base branch from
msm8916/6.1-rc8
to
msm8916/6.1
wonderfulShrineMaidenOfParadise
force-pushed
the
j5
branch
from
b7bbeb3
to
38a761c
Compare
|
I'm not sure what happened, but testing the modified source from on my SM-J500H (3g variant, codename j5), the touchscreen works, but the modem seems to not work, specifically it doesn't detect my SIM card, but otherwise seems to work fine. |
|
@ap4ss3rby I don't see modem regressions for now. Does it always or sometimes happen? |
|
Well I was testing with a nanoSIM, and since the phone has a slot loading microSIM I wasn't pushing the sim into the socket completely, so it seems like its mostly my fault for not inserting it fully (or not using a SIM adapter), otherwise it seems to be working fine (including only recognizing that my phone is 3g only) |
wonderfulShrineMaidenOfParadise
changed the base branch from
msm8916/6.1
to
msm8916/6.2-rc1
wonderfulShrineMaidenOfParadise
force-pushed
the
j5
branch
from
38a761c
to
e35c6f4
Compare
wonderfulShrineMaidenOfParadise
changed the base branch from
msm8916/6.2-rc1
to
msm8916/6.2-rc2
wonderfulShrineMaidenOfParadise
force-pushed
the
j5
branch
4 times, most recently
from
063bbd9
to
8990bb5
Compare
wonderfulShrineMaidenOfParadise
force-pushed
the
j5
branch
from
8990bb5
to
34242d4
Compare
wonderfulShrineMaidenOfParadise
changed the base branch from
msm8916/6.2-rc2
to
msm8916/6.2-rc3
v2: Add suffix "-state" to pinctrl. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
Add support for SMB1360 fuel gauge & charger circuit. Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> v2: Increase timeout to 768 Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
Signed-off-by: André Apitzsch <git@apitzsch.eu> v4: split from initial commit after upstreaming Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: André Apitzsch <git@apitzsch.eu>
Add support for SMB1360 fuel gauge and charger circuit. Signed-off-by: André Apitzsch <git@apitzsch.eu> v2: Increase timeout to 768 Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
Signed-off-by: Adam Słaboń <asaillen@protonmail.com>
Signed-off-by: Adam Słaboń <asaillen@protonmail.com>
Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
… jack detection (v2)" This reverts commit d4d1155. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
…(v4)" This reverts commit 3139bdd. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
This reverts commit 17fc4f5. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
This reverts commit 708d958. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
…(v2)" This reverts commit 742fd5a. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
…l (v4)" This reverts commit 65f020f. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
This reverts commit a7dee29. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
J5 and J5X uses KTD2692 Flash LED driver. Add it to the device tree. Signed-off-by: Markuss Broks <markuss.broks@gmail.com> [Apply for msm8916-samsung-j5x] v2: status = "okay"; by default Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
v2: Make reset-gpios GPIO_ACTIVE_LOW
v3: Add &mdss { status = "okay"; };
Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
v4: Move from msm8916-samsung-j5
Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
v2: Move ®_vdd_lcd_3p0 from common dtsi Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
…tection (v2) v2: Moved from msm8916-samsung-j5x Headset microphone is broken with this on j5x, headphone buttons are broken as well. (Needs more investigation...) Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
…e tree This common dtsi adds support for msm8916 variant of Samsung Galaxy J3 smartphones released in 2016. Add a device tree for J3 with initial support for: - GPIO keys - SDHCI (internal and external storage) - USB Device Mode - UART (on USB connector via the SM5703 MUIC) - WCNSS (WiFi/BT) - Regulators Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
v2: Use msm8916-samsung-j5-common v3: Use msm8916-samsung-j3-common Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
J3 has ST LIS2HH12 accelerometer. Add support for it. v2: Change interrupt to IRQ_TYPE_LEVEL_HIGH Signed-off-by: Stephan Gerhold <stephan@gerhold.net> v3: Move from msm8916-samsung-j5. Set vdd-supply to l5 Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
Add regulators for the panel on J3. Note that l17 is required. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
wonderfulShrineMaidenOfParadise
force-pushed
the
j5
branch
from
a3b8927
to
a23db8e
Compare
wonderfulShrineMaidenOfParadise
changed the base branch from
wip/msm8916/6.8
to
wip/msm8916/6.9
TravMurav
force-pushed
the
wip/msm8916/6.9
branch
2 times, most recently
from
98939cb
to
c4d3662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddDrop j3 in upstreamsamsung-j3to upstream, and include it inmsm8916-mainlineAdd touchscreen to upstream patches Drop touchscreen in upstreamUpstreamed touchscreen partially.msm8916-samsung-j3-common.dtsiLink:
https://lore.kernel.org/lkml/20230106142748.546975-1-linmengbo0689@protonmail.com/
https://lore.kernel.org/lkml/20230715214046.14902-1-linmengbo0689@protonmail.com/
https://lore.kernel.org/lkml/20230904123123.2593-1-linmengbo0689@protonmail.com/