Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse Encoder/Decoder instance #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reuse Encoder/Decoder instance #177

wants to merge 1 commit into from

Conversation

buu700
Copy link

@buu700 buu700 commented May 5, 2021

Addresses #172

@gfx
Copy link
Member

gfx commented May 5, 2021 •
edited

Thank you for the contribution. We need to make sure it's safe when we use this PR in the async/await context.

@gfx
Copy link
Member

gfx commented May 5, 2021

Ah, right. It only changes the synchronous functions, although CI failed. It looks good.

Could you take a look at CI failure? I'll merge this PR if CI passes.

@buu700
Copy link
Author

buu700 commented May 5, 2021

Cool, sounds good. I'll investigate the failure as soon as I have a moment, but just rebased on the tip of main in case that makes a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@buu700 @gfx