Fix: Removes a chance for empty links

msaari · Oct 19, 2021 · 3ff03c7 · 3ff03c7
1 parent e0f9146
commit 3ff03c7
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/common.php b/lib/common.php
@@ -1035,7 +1035,10 @@ function relevanssi_permalink( $link, $link_post = null ) {
 	}
 	// Using property_exists() to avoid troubles from magic variables.
 	if ( is_object( $link_post ) && property_exists( $link_post, 'relevanssi_link' ) ) {
-		$link = $link_post->relevanssi_link;
+		// $link_post->relevanssi_link can still be false.
+		if ( ! empty( $link_post->relevanssi_link ) ) {
+			$link = $link_post->relevanssi_link;
+		}
 	}
 
 	if ( is_search() && is_object( $link_post ) && property_exists( $link_post, 'relevance_score' ) ) {