Preliminary SwiftUI support #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now it will simply add a `UIHostingController` `view` to the `contentView`. I commented out calls needed for proper view controller containment because it doesn’t play well with my `UINavigationController`.
rivera-ernesto
force-pushed
the
swiftui
branch
from
099b6e2
to
d117d53
Compare
|
Added code that properly adds/removes the child view controller calling the corresponding methods on both parent and child controllers. It is cleaner now but it can pose problems with the parent. For instance when using Moreover, it would be cleaner to make |
|
I've noticed that taps in the embed SwiftUI view are not recognized. |
rivera-ernesto
force-pushed
the
swiftui
branch
from
d117d53
to
099b6e2
Compare
…n .portraitUpsideDown
…n .portraitUpsideDown
…ean .isRotateAllowed, .face
…ean .isRotateAllowed, .face
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now it will simply add a
UIHostingControllerviewto thecontentView.I commented out calls needed for proper view controller containment because it doesn’t play well with my
UINavigationController.