Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passes the nonexistent key as a block argument in Array#delete #6266

Merged
merged 2 commits into from May 14, 2024
Merged

Passes the nonexistent key as a block argument in Array#delete #6266

merged 2 commits into from May 14, 2024

Conversation

dearblue
Copy link
Contributor 

a = %w(R G B A)
p a.delete("Y") { _1 }
# BEFORE => nil (same for mruby 3.3)
# AFTER  => "Y" (same for CRuby)

Also, the test code was not present, so I added it.

@dearblue
Add test for Array#delete
c753ca3
@dearblue
Passes the nonexistent key as a block argument in Array#delete
f0cd35c 
```ruby
a = %w(R G B A)
p a.delete("Y") { _1 }
# BEFORE => nil (same for mruby 3.3)
# AFTER  => "Y" (same for CRuby)
```
@dearblue dearblue requested a review from matz as a code owner May 10, 2024 14:00
@github-actions github-actions bot added the core label May 10, 2024
@matz matz merged commit 156c7ec into mruby:master May 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz matz Awaiting requested review from matz matz is a code owner

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dearblue @matz