unify the code for filter methods (and speed up #reject!
)
#6236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the worst case for
Array#reject!
(i.e. a proc always returningtrue
) is at least 5x worse than the worst case forArray#select!
(proc always returningfalse
)this commit unifies these implementations and inlines the (effective) call of
#select!
in#keep_if
and#reject!
in#delete_if