Add rubocop pre-commit hook; Remove redundant returns
#6207
+47
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearblue
reviewed
Mar 16, 2024
We already run Rubocop on `mgem-list` as seen here: https://github.com/mruby/mgem-list/blob/7944a361ab9acb0d673f15fbf0e2ce4b80f21514/.pre-commit-config.yaml#L46 This PR adds a basic Rubocop config file and the goal is to standardize the codebase. Using `rubocop -A` the redundant returns have been autoremoved.
jbampton
force-pushed
the
add-rubocop-hook
branch
from
202a10a
to
c52dda1
Compare
matz
reviewed
Mar 19, 2024
| DisabledByDefault: true | ||
| TargetRubyVersion: 3.3.0 | ||
|
|
||
| Style/RedundantReturn: |
There was a problem hiding this comment.
Is this rule really needed? I am not sure the changes from the rule make the code more readable.
There was a problem hiding this comment.
I started this PR thinking that we could use some rules from Rubocop to help organize and standardize some of the Ruby codebase.
I think it is better to be consistent and removing these redundant returns sets a code standard going forwards. These extra returns are really extra characters and data that is not needed.
Maybe this rule is not needed but I think there could be some other Rubocop rules that are useful for mruby.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already run Rubocop on
mgem-listas seen here:https://github.com/mruby/mgem-list/blob/7944a361ab9acb0d673f15fbf0e2ce4b80f21514/.pre-commit-config.yaml#L46
This PR adds a basic Rubocop config file and the goal is to standardize the codebase.
Using
rubocop -Athe redundant returns have been autoremoved.