-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MRB_NO_DIRECT_THREADING
with MRB_USE_VM_SWITCH_DISPATCH
#5902
Conversation
I am not sure how proposed wording is better. Could you explain? |
🐈⬛ My only source of information is https://ja.wikipedia.org/wiki/スレッデッドコード, which may be suspect.
|
I fixed the conflicts and rebased. |
I understand the wording (and I am sure it's valid, since Prof. Ertl mentioned). But since we see “switch threading” in the reference, so if used precisely, the term threaded code itself is meaningless. Let me think about it for a while. |
Oh, "Switch threading". |
How about |
I prefer the term "switch dispatch" to "switch threading", for not using direct goto. |
The correct technique now is "Token Threading". However, the new name was chosen because it was felt that if a different technique was added in the future, there would be no need to replace it.
Thanks for your comment. And |
MRB_NO_DIRECT_THREADING
with MRB_NO_THREADED_CODE
MRB_NO_DIRECT_THREADING
with MRB_USE_VM_SWITCH_DISPATCH
The correct technique now is "Token Threading".
However, the new name was chosen because it was felt that if a different technique was added in the future, there would be no need to replace it.