Support using internal realm name on components for support with imported realms #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ernstsen
force-pushed
the
internal-realm-name-on-components
branch
2 times, most recently
from
66c3246
to
36b026d
Compare
Created simple backwards-compatible fix for issue mrparkers#802 in realm_keystore implementations By allowing to set realm_internal_id explicitly it allows for imported realms to have the UUID set by keycloak, while not breaking legacy usage of this provider, as they will have realm_id == realm_internal_id. Also added documentation for internal_realm_id arguments
Ernstsen
force-pushed
the
internal-realm-name-on-components
branch
from
36b026d
to
3513f6b
Compare
Ernstsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for components using the internal realm name.
This resolves issue #802
The issue arises as the provider assumes that
realmId==parentIdwhich is not the case for imported realms, as theirparentIdis theinternalIdgenerated by keycloak, which uses an UUID.When the internal id is not set, the behavior defaults to the old one, as to not break any currently supported realms using this provider to manage their keys.