fix: Fix blackscreen issues and lifecycle when closing Camera

[mrousavy]

What

Fixes various blackscreen and out-of-sync issues on Android by deterministically closing and cleaning up the session.

Following changes:

• fix: Fix a scenario where the concurrent configure { ... } mechanism could drop important updates
• fix: Fix Android lifecycle by allowing Android to close the CameraDevice when isActive=false
• fix: Fix Android blackscreens by refactoring CameraSession setup
• fix: Fix "photo/video is not enabled" errors
• perf: Don't re-create anything if session is closing down
• feat: Support 60 FPS on Samsung devices (if available)

Changes

Tested on

Related issues

• Fixes 🐛 photo={true} and keeps returning an error that is not enabled #2343
• Fixes 🐛 3.6.17 Android Regression: Camera blacks out on Android (working fine on 3.6.16) #2340
• Fixes 🐛 (Android) Camera works on initial build and view blacks out on refresh #2330
• Fixes "code": "capture/video-not-enabled", "message": "[capture/video-not-enabled] Video capture is disabled! Pass video={true} to enable video recordings. #2328
• Fixes 🐛 App crashes when trying to open the camera multiple times #2314
• Fixes 🐛 Still face issue andoid black screen when navigate to camera page #2308
• Fixes 🐛 Black Screen in Samsung S22 S23 ultra and some other devices when frame processor is on. #2301
• Fixes 🐛 Android: Intermittent crash going from codeScanner to photo Camera #2294
• Fixes ❓ Getting a Black screen when using camera #2291
• Fixes (ANDROID) Camera black screen when using "codeScanner" on second time screen gets focus 🐛  #2259
• Fixes 🐛 Application closes by itself after scanning a barcode. #2243
• Fixes 🐛 Error: TOO_MANY_OPEN_CAMERAS after reopening camera page #2240
• Fixes [Android] Vision Camera crashing when opening native camera while Barcodescan is mounted 🐛  #2224
• Fixes 🐛 Black screen on camera  #2223
• Fixes 🐛 Android crash - CameraDevice was already closed #2210
• Fixes 🐛 Camera not fully releasing on Android #2201
• Fixes 🐛Camera in some other app or tool the session is closed and not reopened #2197
• Fixes Black screen on the camera preview only with Redmi Note 🐛  #2193
• Fixes Android crash when permission change at background 🐛  #2188
• Fixes 🐛 It crashes on Android after scanning a QRcode #2147
• Fixes 🐛 Camera is not mounting, onInitialized callback is not being called #2143
• Fixes 🐛 App crashes randomly on Android device when navigating back to camera  #2090

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-vision-camera	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 5, 2024 3:01pm

[xseignard]

Hello
I just updated our apps to 3.7.0 and at the first try I have the famous black screen of the not unmounted camera on android 🫤

I'd love to see our sponsoring dedicated to fix lifecycle issues and stability on Android

[mrousavy]

Hey @xseignard - that's weird, I cannot reproduce this bug at all. Is there an open issue for that which uses 3.7.0? Need the adb logcat logs and a reproduction example please.

& thanks for your sponsorship, much appreciated!

[xseignard]

Hey @mrousavy, couldn't recreate in an isolated example
But I reproduced this one #2378

You said this PR fixed #2240, but it seems it does not. May I ask how you tested it fixes the problem?

[mrousavy]

Hey - I tested in the Example app by navigating from and to the code scanner screen. That worked

[xseignard]

Well, looking at all the newly raised issues with 3.7.0 on Android, the example app is definitely not a good proofing 🤷