Merge pull request #6 from zifter/fix-corner-case-with-1-choose

Fix case with 1 choice which have weight equals 1
mroth · Dec 4, 2020 · 0d64275 · 0d64275
2 parents 953da99 + 432cb4b
commit 0d64275
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/weightedrand.go b/weightedrand.go
@@ -52,7 +52,7 @@ func NewChooser(choices ...Choice) (*Chooser, error) {
 		totals[i] = runningTotal
 	}
 
-	if runningTotal <= 1 {
+	if runningTotal < 1 {
 		return nil, errNoValidChoices
 	}
 

diff --git a/weightedrand_test.go b/weightedrand_test.go
@@ -58,6 +58,11 @@ func TestNewChooser(t *testing.T) {
 			cs:      []Choice{{Item: 'a', Weight: 0}, {Item: 'b', Weight: 0}},
 			wantErr: errNoValidChoices,
 		},
+		{
+			name:    "choice with weight equals 1",
+			cs:      []Choice{{Item: 'a', Weight: 1}},
+			wantErr: nil,
+		},
 		{
 			name:    "weight overflow",
 			cs:      []Choice{{Item: 'a', Weight: maxInt/2 + 1}, {Item: 'b', Weight: maxInt/2 + 1}},