[DRAFT] Support for TruffleRuby/GraalVM #125
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into graalvm-ify
…stefreschke/pycall.rb into use-conversion-for-type-matches
…stefreschke/pycall.rb into use-conversion-for-type-matches � Conflicts: � lib/pycall/truffleruby/pyobject_wrapper.rb
…stefreschke/pycall.rb into use-conversion-for-type-matches
…stefreschke/pycall.rb into use-conversion-for-type-matches � Conflicts: � lib/pycall/truffleruby/conversion.rb
…stefreschke/pycall.rb into use-conversion-for-type-matches
…stefreschke/pycall.rb into use-conversion-for-type-matches
…stefreschke/pycall.rb into use-conversion-for-type-matches � Conflicts: � lib/pycall/truffleruby/dict.rb � lib/pycall/truffleruby/pycall.rb � lib/pycall/truffleruby/pytypeobject_wrapper.rb � lib/pycall/truffleruby/slice.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a university project we tried to explore different options to support PyCall running on TruffleRuby (GraalVM). The choices we made are:
RUBY_ENGINE=='truffleruby'In the current form it's working fine and passes almost all Unit Tests (except some that depend on native extensions and half of spec/conversion_spec.rb), but judging by code-review by @eregon the current structure of having duplicated code for the TruffleRuby variant might make it unmaintainable. Our thought was that merging the code and adding a lot of
if RUBY_ENGINE=='truffleruby'might also be suboptimal.We would like to ask you for your feedback: What do you think? What should be improved? How do you feel about enabling PyCall to run on TruffleRuby (GraalVM)?
(/cc @stefreschke @eregon @fniephaus)