WebGPURenderer: fix createBindGroup warnings when use videoTexture in webgpu mode [Draft] #28369
+36
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z4122
force-pushed
the
fix/webgpu_externaltexture_warning
branch
2 times, most recently
from
039381e
to
007e7c0
Compare
z4122
changed the title
|
I'm getting this message of error most part of times that I tested: 
|
|
|
||
| if ( binding.texture.source !== undefined && binding.texture.source.data !== undefined ) { | ||
|
|
||
| textureData.externalTexture = binding.texture.source.data; |
There was a problem hiding this comment.
What's the difference in all this code compared to the binding.isSampledTexture condition except this one line and binding.texture.source !== undefined && binding.texture.source.data !== undefined part?
I think it could be moved into the next block instead.
There was a problem hiding this comment.
Also I get the same error as Sunag.
z4122
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #27690
Description
When open exmaples , multi warnings will be printed
The reason is, in the beginning, video texture is not set correctly. it should be an external texture, but it is initialed as a normal texture view.
Later, the external texture is set in WebGPUTextureUtils.js. So the second frame is correct.
To solve this problem, we should set external texture correctly in the first frame.