Editor: Fixed material-related commands

[ycw]

Related: #28345 ( issue 3 )

Issue: All material related commands SetMaterialXXXCommand are failed to UNDO/REDO

In execute() and undo(), the material is referencing to the one cached at construction time, it may not be the same material that materialChanged signal is dispatching for.

This PR fixed that by getting material via given object, materialSlot in execute() and undo(), instead of using cached one, s.t. it must be the same material as the one materialChanged is dispatching for:

const material = this.editor.getObjectMaterial( this.object, this.materialSlot )

// do stuff with material

this.editor.signals.materialChanged.dispatch( this.object, this.materialSlot )

[mrdoob]

Issue: All material related commands SetMaterialXXXCommand are failed to UNDO/REDO

Are they?

Screen.Recording.2024-05-17.at.5.31.34.PM.mov

[ycw]

Issue: All material related commands SetMaterialXXXCommand are failed to UNDO/REDO

Are they?

Screen.Recording.2024-05-17.at.5.31.34.PM.mov

yes, for the SetMaterialXXXCommand listed 'how to test' section in #28345

[ycw]

would be great if you closes a PR with a reason...

[Mugen87]

Sorry, when they are linked in other PRs, they get automatically closed.

[mrdoob]

yes, for the SetMaterialXXXCommand listed 'how to test' section in #28345

Do you mind explaining it again here? I don't understand the description.

[ycw]

yes, for the SetMaterialXXXCommand listed 'how to test' section in #28345

Do you mind explaining it again here? I don't understand the description.

This PR fixed these commands listed in #28345 'How to test':

list:

The video #28362 (comment) you posted was testing just one of them.