WebGPURenderer: Tight morph target packing #27984

RenaudRohlinger · 2024-03-24T08:13:25Z

Related issue: #27768

Description
Adapted the tight morph target packing PR to the WebGPURenderer fo testing purpose.

Benchmark on webgpu_instancing_morph using stats-gl on Mac Book Pro M1 Max:

stats = new Stats( {
	logsPerSecond: 0.25,
	samplesLog: 1000,
	precision: 3
} );

WebGL:
Before: 4.2ms GPU average
After: 4.4ms GPU average

WebGPU:
Before: 4.1ms GPU average
After: 4.5ms GPU average

Tight pack through Red Channel seems inefficient and GPUs seems to always prefer using RGBA?

This contribution is funded by Utsubo

examples/jsm/nodes/accessors/MorphNode.js

 import { loop } from '../utils/LoopNode.js';
+import { all } from '../Nodes.js';


RenaudRohlinger · 2024-03-24T08:43:39Z

Will close it for now as it feels like a regression. I will reopen it if proven otherwise.

RenaudRohlinger added 2 commits March 24, 2024 17:10

tight pack

64861d5

remove all in tsl

7dffe60

github-advanced-security bot found potential problems Mar 24, 2024

View reviewed changes

examples/jsm/nodes/accessors/MorphNode.js

import { loop } from '../utils/LoopNode.js';

import { all } from '../Nodes.js';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import all.

RenaudRohlinger closed this Mar 24, 2024

RenaudRohlinger mentioned this pull request Mar 24, 2024

WebGLRenderer: Tight morph target packing. #27768

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WebGPURenderer: Tight morph target packing #27984

WebGPURenderer: Tight morph target packing #27984

RenaudRohlinger commented Mar 24, 2024 •

edited

RenaudRohlinger commented Mar 24, 2024 •

edited

		import { loop } from '../utils/LoopNode.js';
		import { all } from '../Nodes.js';

WebGPURenderer: Tight morph target packing #27984

WebGPURenderer: Tight morph target packing #27984

Conversation

RenaudRohlinger commented Mar 24, 2024 • edited

RenaudRohlinger commented Mar 24, 2024 • edited

RenaudRohlinger commented Mar 24, 2024 •

edited

RenaudRohlinger commented Mar 24, 2024 •

edited