New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextGeometry changes and support in editor #27931
Open
zz85
wants to merge
11
commits into
mrdoob:dev
Choose a base branch
from
zz85:textedit
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+257
−5
Commits on Mar 16, 2024
-
TextGeometry changes and support in editor
- add support for TextGeometry in editor. currently this is linked only to a single font, but all of TextGeometry functionality is wired to the editor's sidebar UI, which I think is more than sufficient now - depreciating `height` parameter in TextGeometry options for `depth` for consistency with ExtrudeGeometry, which refers to the thickness the Text will be extruded. using `height` is still supported but will emit a warning in the console - also added a `scale` parameter in TextGeometry and editor. The numbers that work well for font sizes is unusally large in three.js objects (esp in VR), so passing 0.01 makes it more the conversion more pleasant to work with - Serialization and deserialization works. toJSON() and fromJSON() is added to TextGeometry. I have to add this to Geometries.js for scene loading to work automatically in editor, but the dependency of an addon (TextGeometry is addon, ExtrudeGeometry is core) seems a little strange. Either there's a better way to extend the supported Geometries deserialization list or perhaps move TextGeometry out of the examples
Configuration menu - View commit details
-
Copy full SHA for bea5c1f - Browse repository at this point
Copy the full SHA bea5c1fView commit details
Commits on Mar 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for be77eef - Browse repository at this point
Copy the full SHA be77eefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33a29dd - Browse repository at this point
Copy the full SHA 33a29ddView commit details
Commits on Mar 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e646d48 - Browse repository at this point
Copy the full SHA e646d48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89d73f3 - Browse repository at this point
Copy the full SHA 89d73f3View commit details -
Add `@deprecated` annotation, update warning text.
Configuration menu - View commit details
-
Copy full SHA for b7645d8 - Browse repository at this point
Copy the full SHA b7645d8View commit details
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 67ae50e - Browse repository at this point
Copy the full SHA 67ae50eView commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 575e31d - Browse repository at this point
Copy the full SHA 575e31dView commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cf8174b - Browse repository at this point
Copy the full SHA cf8174bView commit details
Commits on Apr 4, 2024
-
Rename `this.Geometries` to `this.geometryTypes`.
Configuration menu - View commit details
-
Copy full SHA for 809ffb6 - Browse repository at this point
Copy the full SHA 809ffb6View commit details
Commits on Apr 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 24fe50f - Browse repository at this point
Copy the full SHA 24fe50fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.