add Material serialization hook #14259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
onBeforeCompileand serialization.I find it odd that
Materialsuper class is aware of all the properties of all the sub classed materials:https://github.com/mrdoob/three.js/blob/dev/src/materials/Material.js#L165-L166
Serialization has been cited as a problem with shader injections. However, with this i was able to write my own properties with the
myExtendedMaterial.toJSON()as well as store references to textures.#14231
What are generally the pain points of serializing this stuff?
userDatais also serialized and could be overloaded with anything, but it would make more sense to control what's included from the level of the owner of the properties.