Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFExporter: Allow for 4-byte alignment requirement in processBufferView #13419

Closed
wants to merge 3 commits into from
Closed

GLTFExporter: Allow for 4-byte alignment requirement in processBufferView #13419

wants to merge 3 commits into from

Conversation

webprofusion-chrisc
Copy link
Contributor

Along the same lines as #13220 this fixes validation for accessor offset by padding length to next 4-byte boundary.

@mrdoob mrdoob added this to the r91 milestone Feb 24, 2018
@webprofusion-chrisc
Copy link
Contributor Author

btw, this is in part to provide further support for facebook posts #13397

@mrdoob mrdoob changed the title Allow for 4-byte alignment requirement in processBufferView GLTFExporter: Allow for 4-byte alignment requirement in processBufferView Feb 25, 2018
@mrdoob
Copy link
Owner

mrdoob commented Feb 25, 2018

/ping @fernandojsg @takahirox

@fernandojsg
Copy link
Collaborator

We are computing the same value two times, on processBuffer https://github.com/mrdoob/three.js/blob/dev/examples/js/exporters/GLTFExporter.js#L276 and on processBufferView (as you proposed).
What about adding it as a parameter to processBuffer https://github.com/mrdoob/three.js/blob/dev/examples/js/exporters/GLTFExporter.js#L338 so we don't need to compute it again there?

@fernandojsg
Copy link
Collaborator

This is not needed after #12877
@mrdoob we could close it

@mrdoob mrdoob closed this Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants