Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ImageUtils #12712

Merged
merged 2 commits into from Nov 22, 2017
Merged

Removed ImageUtils #12712

merged 2 commits into from Nov 22, 2017

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 20, 2017

Removed the deprecated ImageUtils. The code of this file was not used in the entire repo anymore.

@tentone
Copy link
Contributor

tentone commented Nov 20, 2017

Hi i would prefer to move this to a examples/js/utils folder.

I think that the ImageUtils class migth be of help sometimes.

@donmccurdy
Copy link
Collaborator

@tentone It's in examples already — was there a particular part that looks helpful?

I think generateDataTexture seems fairly trivial, and could just be an example in the docs for THREE.DataTexture.

Computing a normal map from a height map is more complex, but there's no threejs-specific code in that at all, and you can find essentially the same source code on www.paulbrunt.co.uk/lab/heightnormal/ or #427.

So for me, +1 on removing ImageUtils, and we can add links to any appropriate resources instead.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 20, 2017

I think generateDataTexture seems fairly trivial, and could just be an example in the docs for THREE.DataTexture.

Good idea! I'll add the code to the documentation page.

@tentone
Copy link
Contributor

tentone commented Nov 20, 2017

Totally agree.

I only see value in the normal map generator as well, the datatexture generator is really simple.

But i also don't have any specific reason to remove it from the repo, i find it to be useful and it is not part of the core anyway.

@donmccurdy
Copy link
Collaborator

But i also don't have any specific reason to remove it from the repo, i find it to be useful and it is not part of the core anyway.

It's just more to maintain is the issue; ideally the examples/js/* folder should contain examples of three.js-specific things. A generic WebGL example like this would be better in a blog post or GitHub gist somewhere.

@mrdoob
Copy link
Owner

mrdoob commented Nov 22, 2017

I only see value in the normal map generator as well.

I think that code will be more useful in texgen.js 😊 #todolist

@mrdoob mrdoob merged commit 7c49ff1 into mrdoob:dev Nov 22, 2017
@mrdoob
Copy link
Owner

mrdoob commented Nov 22, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants