Merge pull request #10140 from TristanVALCKE/example_warning_fix

Example warning fix
mrdoob · Nov 16, 2016 · e8ad809 · e8ad809
2 parents cf16452 + 62e9cf5
commit e8ad809
Show file tree

Hide file tree

Showing 140 changed files with 422 additions and 439 deletions.
diff --git a/examples/css3d_molecules.html b/examples/css3d_molecules.html
@@ -380,7 +380,7 @@
 
 						}
 
-						colorSprite = colorSpriteMap[ element ];
+						var colorSprite = colorSpriteMap[ element ];
 
 						var atom = document.createElement( 'img' );
 						atom.src = colorSprite;

diff --git a/examples/index.html b/examples/index.html
@@ -244,7 +244,7 @@ <h1><a href="http://threejs.org">three.js</a> / examples</h1>
 		<script>
 
 		function extractQuery() {
-			var p = window.location.search.indexOf( '?q=' )
+			var p = window.location.search.indexOf( '?q=' );
 			if( p !== -1 ) {
 				return window.location.search.substr( 3 );
 			}
@@ -383,7 +383,7 @@ <h1><a href="http://threejs.org">three.js</a> / examples</h1>
 			} else {
 				window.history.replaceState( {} , '', window.location.pathname );
 			}
-			if( selected ) window.location.hash = selected
+			if( selected ) window.location.hash = selected;
 
 			var exp = new RegExp( v, 'gi' );
 
@@ -473,7 +473,7 @@ <h1><a href="http://threejs.org">three.js</a> / examples</h1>
 
 		}
 
-		filterInput.value = extractQuery()
+		filterInput.value = extractQuery();
 		updateFilter( )
 
 		</script>

diff --git a/examples/js/BlendCharacter.js b/examples/js/BlendCharacter.js
@@ -39,7 +39,6 @@ THREE.BlendCharacter = function () {
 			scope.material.skinning = true;
 
 			scope.mixer = new THREE.AnimationMixer( scope );
-			scope.mixer = scope.mixer;
 
 			// Create the animations
 			for ( var i = 0; i < scope.geometry.animations.length; ++ i ) {
@@ -129,7 +128,7 @@ THREE.BlendCharacter = function () {
 
 		return this.mixer.clipAction( animName ).getEffectiveWeight();
 
-	}
+	};
 
 	this.pauseAll = function() {
 
@@ -154,7 +153,7 @@ THREE.BlendCharacter = function () {
 
 		this.visible = boolean;
 
-	}
+	};
 
 };
 

diff --git a/examples/js/Encodings.js b/examples/js/Encodings.js
@@ -5,7 +5,7 @@
 
 THREE.Encodings = function() {
   if( THREE.toHalf === undefined ) throw new Error("THREE.Encodings is required for HDRCubeMapLoader when loading half data.");
-}
+};
 
 THREE.Encodings.RGBEByteToRGBFloat = function( sourceArray, sourceOffset, destArray, destOffset ) {
   var e = sourceArray[sourceOffset+3];
@@ -14,7 +14,7 @@ THREE.Encodings.RGBEByteToRGBFloat = function( sourceArray, sourceOffset, destAr
   destArray[destOffset+0] = sourceArray[sourceOffset+0] * scale;
   destArray[destOffset+1] = sourceArray[sourceOffset+1] * scale;
   destArray[destOffset+2] = sourceArray[sourceOffset+2] * scale;
-}
+};
 
 THREE.Encodings.RGBEByteToRGBHalf = function( sourceArray, sourceOffset, destArray, destOffset ) {
   var e = sourceArray[sourceOffset+3];
@@ -23,4 +23,4 @@ THREE.Encodings.RGBEByteToRGBHalf = function( sourceArray, sourceOffset, destArr
   destArray[destOffset+0] = THREE.toHalf( sourceArray[sourceOffset+0] * scale );
   destArray[destOffset+1] = THREE.toHalf( sourceArray[sourceOffset+1] * scale );
   destArray[destOffset+2] = THREE.toHalf( sourceArray[sourceOffset+2] * scale );
-}
+};
diff --git a/examples/js/GPUComputationRenderer.js b/examples/js/GPUComputationRenderer.js
@@ -258,7 +258,7 @@ function GPUComputationRenderer( sizeX, sizeY, renderer ) {
 
 		materialShader.defines.resolution = 'vec2( ' + sizeX.toFixed( 1 ) + ', ' + sizeY.toFixed( 1 ) + " )";
 
-	};
+	}
 	this.addResolutionDefine = addResolutionDefine;
 
 
@@ -277,7 +277,7 @@ function GPUComputationRenderer( sizeX, sizeY, renderer ) {
 		addResolutionDefine( material );
 
 		return material;
-	};
+	}
 	this.createShaderMaterial = createShaderMaterial;
 
 	this.createRenderTarget = function( sizeXTexture, sizeYTexture, wrapS, wrapT, minFilter, magFilter ) {
@@ -367,4 +367,4 @@ function GPUComputationRenderer( sizeX, sizeY, renderer ) {
 
 	}
 
-}
+}
diff --git a/examples/js/GPUParticleSystem.js b/examples/js/GPUParticleSystem.js
@@ -200,7 +200,7 @@ THREE.GPUParticleSystem = function(options) {
 
 	self.random = function() {
 		return ++i >= self.rand.length ? self.rand[i = 1] : self.rand[i];
-	}
+	};
 
 	var textureLoader = new THREE.TextureLoader();
 
@@ -252,7 +252,7 @@ THREE.GPUParticleSystem = function(options) {
 
 		}
 
-	}
+	};
 
 	this.spawnParticle = function(options) {
 
@@ -265,7 +265,7 @@ THREE.GPUParticleSystem = function(options) {
 
 		currentContainer.spawnParticle(options);
 
-	}
+	};
 
 	this.update = function(time) {
 		for (var i = 0; i < self.PARTICLE_CONTAINERS; i++) {
@@ -277,7 +277,7 @@ THREE.GPUParticleSystem = function(options) {
 
 	this.init();
 
-}
+};
 
 THREE.GPUParticleSystem.prototype = Object.create(THREE.Object3D.prototype);
 THREE.GPUParticleSystem.prototype.constructor = THREE.GPUParticleSystem;
@@ -299,14 +299,14 @@ THREE.GPUParticleContainer = function(maxParticles, particleSystem) {
 	THREE.Object3D.apply(this, arguments);
 
 	// construct a couple small arrays used for packing variables into floats etc
-	var UINT8_VIEW = new Uint8Array(4)
-	var FLOAT_VIEW = new Float32Array(UINT8_VIEW.buffer)
+	var UINT8_VIEW = new Uint8Array(4);
+	var FLOAT_VIEW = new Float32Array(UINT8_VIEW.buffer);
 
 	function decodeFloat(x, y, z, w) {
-		UINT8_VIEW[0] = Math.floor(w)
-		UINT8_VIEW[1] = Math.floor(z)
-		UINT8_VIEW[2] = Math.floor(y)
-		UINT8_VIEW[3] = Math.floor(x)
+		UINT8_VIEW[0] = Math.floor(w);
+		UINT8_VIEW[1] = Math.floor(z);
+		UINT8_VIEW[2] = Math.floor(y);
+		UINT8_VIEW[3] = Math.floor(x);
 		return FLOAT_VIEW[0]
 	}
 
@@ -329,7 +329,7 @@ THREE.GPUParticleContainer = function(maxParticles, particleSystem) {
 		if (b > 0) b--;
 
 		return [r, g, b];
-	};
+	}
 
 	self.particles = [];
 	self.deadParticles = [];
@@ -366,7 +366,7 @@ THREE.GPUParticleContainer = function(maxParticles, particleSystem) {
 	self.particleShaderGeo.addAttribute('particlePositionsStartTime', new THREE.BufferAttribute(self.particlePositionsStartTime, 4).setDynamic(true));
 	self.particleShaderGeo.addAttribute('particleVelColSizeLife', new THREE.BufferAttribute(self.particleVelColSizeLife, 4).setDynamic(true));
 
-	self.posStart = self.particleShaderGeo.getAttribute('particlePositionsStartTime')
+	self.posStart = self.particleShaderGeo.getAttribute('particlePositionsStartTime');
 	self.velCol = self.particleShaderGeo.getAttribute('particleVelColSizeLife');
 
 	self.particleShaderMat = self.GPUParticleSystem.particleShaderMat;
@@ -388,6 +388,7 @@ THREE.GPUParticleContainer = function(maxParticles, particleSystem) {
 		lifetime = 0.,
 		size = 0.,
 		sizeRandomness = 0.,
+		smoothPosition = false,
 		i;
 
 	var maxVel = 2;
@@ -409,8 +410,8 @@ THREE.GPUParticleContainer = function(maxParticles, particleSystem) {
 		turbulence = options.turbulence !== undefined ? options.turbulence : 1.0;
 		lifetime = options.lifetime !== undefined ? options.lifetime : 5.0;
 		size = options.size !== undefined ? options.size : 10;
-		sizeRandomness = options.sizeRandomness !== undefined ? options.sizeRandomness : 0.0,
-			smoothPosition = options.smoothPosition !== undefined ? options.smoothPosition : false;
+		sizeRandomness = options.sizeRandomness !== undefined ? options.sizeRandomness : 0.0;
+		smoothPosition = options.smoothPosition !== undefined ? options.smoothPosition : false;
 
 		if (self.DPR !== undefined) size *= self.DPR;
 
@@ -467,7 +468,7 @@ THREE.GPUParticleContainer = function(maxParticles, particleSystem) {
 
 		self.particleUpdate = true;
 
-	}
+	};
 
 	this.update = function(time) {
 
@@ -497,11 +498,11 @@ THREE.GPUParticleContainer = function(maxParticles, particleSystem) {
 			self.offset = 0;
 			self.count = 0;
 		}
-	}
+	};
 
 	this.init();
 
-}
+};
 
 THREE.GPUParticleContainer.prototype = Object.create(THREE.Object3D.prototype);
 THREE.GPUParticleContainer.prototype.constructor = THREE.GPUParticleContainer;
diff --git a/examples/js/MarchingCubes.js b/examples/js/MarchingCubes.js
@@ -412,7 +412,7 @@ THREE.MarchingCubes = function ( resolution, material, enableUvs, enableColors )
 
 		}
 
-	};
+	}
 
 	this.begin = function () {
 
@@ -493,8 +493,8 @@ THREE.MarchingCubes = function ( resolution, material, enableUvs, enableColors )
 
 		for ( z = min_z; z < max_z; z ++ ) {
 
-			z_offset = this.size2 * z,
-			fz = z / this.size - ballz,
+			z_offset = this.size2 * z;
+			fz = z / this.size - ballz;
 			fz2 = fz * fz;
 
 			for ( y = min_y; y < max_y; y ++ ) {

diff --git a/examples/js/Ocean.js b/examples/js/Ocean.js
@@ -31,9 +31,9 @@
 	this.geometrySize = optionalParameter( options.GEOMETRY_SIZE, 2000 );
 	this.resolution = optionalParameter( options.RESOLUTION, 64 );
 	this.floatSize = optionalParameter( options.SIZE_OF_FLOAT, 4 );
-	this.windX = optionalParameter( options.INITIAL_WIND[ 0 ], 10.0 ),
-	this.windY = optionalParameter( options.INITIAL_WIND[ 1 ], 10.0 ),
-	this.size = optionalParameter( options.INITIAL_SIZE, 250.0 ),
+	this.windX = optionalParameter( options.INITIAL_WIND[ 0 ], 10.0 );
+	this.windY = optionalParameter( options.INITIAL_WIND[ 1 ], 10.0 );
+	this.size = optionalParameter( options.INITIAL_SIZE, 250.0 );
 	this.choppiness = optionalParameter( options.INITIAL_CHOPPINESS, 1.5 );
 
 	//

diff --git a/examples/js/RollerCoaster.js b/examples/js/RollerCoaster.js
@@ -265,19 +265,19 @@ var RollerCoasterLiftersGeometry = function ( curve, size ) {
 			var point1 = shape[ j ];
 			var point2 = shape[ ( j + 1 ) % jl ];
 
-			vector1.copy( point1 )
+			vector1.copy( point1 );
 			vector1.applyQuaternion( quaternion );
 			vector1.add( fromPoint );
 
-			vector2.copy( point2 )
+			vector2.copy( point2 );
 			vector2.applyQuaternion( quaternion );
 			vector2.add( fromPoint );
 
-			vector3.copy( point2 )
+			vector3.copy( point2 );
 			vector3.applyQuaternion( quaternion );
 			vector3.add( toPoint );
 
-			vector4.copy( point1 )
+			vector4.copy( point1 );
 			vector4.applyQuaternion( quaternion );
 			vector4.add( toPoint );
 

diff --git a/examples/js/SkyShader.js b/examples/js/SkyShader.js
@@ -98,7 +98,7 @@ THREE.ShaderLib[ 'sky' ] = {
 			// mie coefficients
 			"vBetaM = totalMie(lambda, turbidity) * mieCoefficient;",
 
-		"}",
+		"}"
 
 	].join( "\n" ),
 
@@ -201,7 +201,7 @@ THREE.ShaderLib[ 'sky' ] = {
 			"gl_FragColor.rgb = retColor;",
 
 			"gl_FragColor.a = 1.0;",
-		"}",
+		"}"
 
 	].join( "\n" )
 

diff --git a/examples/js/UCSCharacter.js b/examples/js/UCSCharacter.js
@@ -8,8 +8,8 @@ THREE.UCSCharacter = function() {
 
 	this.root = new THREE.Object3D();
 
-	this.numSkins;
-	this.numMorphs;
+	this.numSkins = undefined;
+	this.numMorphs = undefined;
 
 	this.skins = [];
 	this.materials = [];

diff --git a/examples/js/Volume.js b/examples/js/Volume.js
@@ -75,7 +75,6 @@ THREE.Volume = function( xLength, yLength, zLength, type, arrayBuffer ) {
 			case 'uint32' :
 			case 'uint' :
 			case 'unsigned int' :
-			case 'uint32' :
 			case 'uint32_t' :
 				this.data = new Uint32Array( arrayBuffer );
 				break;
@@ -188,7 +187,7 @@ THREE.Volume = function( xLength, yLength, zLength, type, arrayBuffer ) {
 	 * @member {Array} RASDimensions This array holds the dimensions of the volume in the RAS space
 	 */
 
-}
+};
 
 THREE.Volume.prototype = {
 
@@ -445,4 +444,4 @@ THREE.Volume.prototype = {
 
 	}
 
-}
+};
diff --git a/examples/js/VolumeSlice.js b/examples/js/VolumeSlice.js
@@ -85,7 +85,7 @@ THREE.VolumeSlice = function( volume, index, axis ) {
 	 */
 
 
-}
+};
 
 THREE.VolumeSlice.prototype = {
 
@@ -214,4 +214,4 @@ THREE.VolumeSlice.prototype = {
 
 	}
 
-}
+};
diff --git a/examples/js/animation/MMDPhysics.js b/examples/js/animation/MMDPhysics.js
@@ -634,7 +634,7 @@ THREE.MMDPhysics.ResourceHelper.prototype = {
 		q.setW( w );
 		return q;
 
-	},
+	}
 
 };
 
@@ -678,7 +678,7 @@ THREE.MMDPhysics.RigidBody.prototype = {
 
 			}
 
-		};
+		}
 
 		var helper = this.helper;
 		var params = this.params;
@@ -871,7 +871,7 @@ THREE.MMDPhysics.RigidBody.prototype = {
 
 		thQ.set( q.x(), q.y(), q.z(), q.w() );
 		thQ2.setFromRotationMatrix( this.bone.matrixWorld );
-		thQ2.conjugate()
+		thQ2.conjugate();
 		thQ2.multiply( thQ );
 
 		//this.bone.quaternion.multiply( thQ2 );

diff --git a/examples/js/controls/DragControls.js b/examples/js/controls/DragControls.js
@@ -232,4 +232,4 @@ THREE.DragControls = function( _camera, _objects, _domElement ) {
 
 	}
 
-}
+};
diff --git a/examples/js/controls/EditorControls.js b/examples/js/controls/EditorControls.js
@@ -13,9 +13,9 @@ THREE.EditorControls = function ( object, domElement ) {
 
 	this.enabled = true;
 	this.center = new THREE.Vector3();
-	this.panSpeed = 0.001
-	this.zoomSpeed = 0.001
-	this.rotationSpeed = 0.005
+	this.panSpeed = 0.001;
+	this.zoomSpeed = 0.001;
+	this.rotationSpeed = 0.005;
 
 	// internals