Consider skinning / instancing when sorting objects

mrdoob · Apr 12, 2024 · d90f2cc · d90f2cc
1 parent 454ada9
commit d90f2cc
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/src/renderers/webgl/WebGLRenderLists.js b/src/renderers/webgl/WebGLRenderLists.js
@@ -12,6 +12,10 @@ function painterSortStable( a, b ) {
 
 		return a.material.id - b.material.id;
 
+	} else if ( a.materialVariant !== b.materialVariant ) {
+
+		return a.materialVariant - b.materialVariant;
+
 	} else if ( a.z !== b.z ) {
 
 		return a.z - b.z;
@@ -66,6 +70,15 @@ function WebGLRenderList() {
 
 	}
 
+	function materialVariant( object ) {
+
+		let variant = 0;
+		if ( object.isInstancedMesh ) variant += 2;
+		if ( object.isSkinnedMesh ) variant += 1;
+		return variant;
+
+	}
+
 	function getNextRenderItem( object, geometry, material, groupOrder, z, group ) {
 
 		let renderItem = renderItems[ renderItemsIndex ];
@@ -77,6 +90,7 @@ function WebGLRenderList() {
 				object: object,
 				geometry: geometry,
 				material: material,
+				materialVariant: materialVariant( object ),
 				groupOrder: groupOrder,
 				renderOrder: object.renderOrder,
 				z: z,
@@ -91,6 +105,7 @@ function WebGLRenderList() {
 			renderItem.object = object;
 			renderItem.geometry = geometry;
 			renderItem.material = material;
+			renderItem.materialVariant = materialVariant( object );
 			renderItem.groupOrder = groupOrder;
 			renderItem.renderOrder = object.renderOrder;
 			renderItem.z = z;

diff --git a/test/unit/src/renderers/webgl/WebGLRenderLists.tests.js b/test/unit/src/renderers/webgl/WebGLRenderLists.tests.js
@@ -78,6 +78,7 @@ export default QUnit.module( 'Renderers', () => {
 						object: objA,
 						geometry: geoA,
 						material: matA,
+						materialVariant: 0,
 						groupOrder: 0,
 						renderOrder: 0,
 						z: 0.5,
@@ -96,6 +97,7 @@ export default QUnit.module( 'Renderers', () => {
 						object: objB,
 						geometry: geoB,
 						material: matB,
+						materialVariant: 0,
 						groupOrder: 1,
 						renderOrder: 0,
 						z: 1.5,
@@ -114,6 +116,7 @@ export default QUnit.module( 'Renderers', () => {
 						object: objC,
 						geometry: geoC,
 						material: matC,
+						materialVariant: 0,
 						groupOrder: 2,
 						renderOrder: 0,
 						z: 2.5,
@@ -132,6 +135,7 @@ export default QUnit.module( 'Renderers', () => {
 						object: objD,
 						geometry: geoD,
 						material: matD,
+						materialVariant: 0,
 						groupOrder: 3,
 						renderOrder: 0,
 						z: 3.5,
@@ -172,6 +176,7 @@ export default QUnit.module( 'Renderers', () => {
 						object: objA,
 						geometry: geoA,
 						material: matA,
+						materialVariant: 0,
 						groupOrder: 0,
 						renderOrder: 0,
 						z: 0.5,
@@ -190,6 +195,7 @@ export default QUnit.module( 'Renderers', () => {
 						object: objB,
 						geometry: geoB,
 						material: matB,
+						materialVariant: 0,
 						groupOrder: 1,
 						renderOrder: 0,
 						z: 1.5,
@@ -208,6 +214,7 @@ export default QUnit.module( 'Renderers', () => {
 						object: objC,
 						geometry: geoC,
 						material: matC,
+						materialVariant: 0,
 						groupOrder: 2,
 						renderOrder: 0,
 						z: 2.5,
@@ -226,6 +233,7 @@ export default QUnit.module( 'Renderers', () => {
 						object: objD,
 						geometry: geoD,
 						material: matD,
+						materialVariant: 0,
 						groupOrder: 3,
 						renderOrder: 0,
 						z: 3.5,