Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1040
This PR is still in the works, but carrys over from @ralight's PR for Unix Domain Sockets support for MQTT.js. I see there is lots of discussion around MQTT.js in Mosquitto that @ralight has participated in, and the resolution was something along the lines of, there is an actionable and useful security gain for having unix domain socket support for a service like mosquitto, so they are looking to add it.
From the MQTT.js perspective, this should be a minimal change. This PR is not complete quite yet, I think I have added some of the changes to make it work, but I want to add a unix domain sockets sample and also add the tests to support it.
For the tests, it should be very simple, just adding on a new flavor of the existing MQTT-Connection based server, except in this case listening on a unix domain port. There should be a check that the tests are running on a POSIX OS (i.e. not Windows) since obviously the tests will fail without the support of unix domain sockets on the OS.