feat: add support for files/unix sockets #1048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoDaMa
requested changes
Feb 12, 2020
|
Sure thing, could you give me a hint on where to start? |
|
https://github.com/mqttjs/MQTT.js/blob/master/test/client.js is the tests for the regular MQTT.js client, and you'll note this test extends the abstact_client.js tests. Following this model but for the specific connection type should be the best option. Instead of a regular HTTPServer though you'll need something specific for the Unix Domain Socket. |
|
@ralight Could you add the required tests please? |
robertsLando
changed the title
|
If you wish to continue with this PR please remember to change destination branch from |
|
This is already possible with standard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1040.