add missing unit symbols for ohm #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpusz
reviewed
May 11, 2024
| inline constexpr auto mohm = milli<si::ohm>; | ||
| inline constexpr auto cohm = centi<si::ohm>; | ||
| inline constexpr auto dohm = deci<si::ohm>; | ||
| inline constexpr auto ohm = si::ohm; |
There was a problem hiding this comment.
I did not add those exactly because of that. If someone does a using-directive on both si and si::unit_symbols, then ohm will be ambiguous. I still am not sure it that is an issue or not. @JohelEGP, do you have an opinion here?
There was a problem hiding this comment.
Hm. Actually, I'm doing that myself:
namespace some_relevant_namespace_for_my_code {
namespace u {
using namespace mp_units;
using namespace mp_units::si;
using namespace mp_units::isq;
using namespace mp_units::si::unit_symbols;
}
}Maybe I never use plain ohm anywhere? I would definitely want to have some kind of prefixed ohm units somewhere - maybe we keep the rest and skip the plain ohm? Altentatively, the v1 "references" kR etc... did not have this isssue, but are obvisously somewhat non-standard.
mpusz
requested changes
May 14, 2024
Co-authored-by: Mateusz Pusz <mateusz.pusz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a question here if
ohmis actually a unit symbol in addition to being a unit name, but havingkohmin the library is definitely helpful. Of course with unicode symbol names, we would want to useΩinstead (or in addition).