Rewrite code for better readability and performance #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the JS files: recomputed salt and iv bytes, changed hexStringToBytes to something performs faster and is easier to read, removed unnecessary comments, and instead used self-explanatory variable names, replaced all quotes with either '' or ``, added ; at the end of each line. In the CSS and HTML: used fewer lines of code, to have a better view for the JS code, since that is the main focus of bounty.html.
dumblob
reviewed
Dec 24, 2022
Turned `decrypt()` into 2 functions, `decrypt()` which simply decrypts the cipher with the given password, salt, iv, and `decrypt_dom()` which runs when the user clicks on the decrypt button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the JS files: precomputed salt and iv bytes, changed hexStringToBytes to something performs faster and is easier to read, removed unnecessary comments, and instead used self-explanatory variable names, replaced all quotes with either '' or ``, added ; at the end of each line.
In the CSS and HTML: used fewer lines of code, to have a better view for the JS code, since that is the main focus of bounty.html.