Use std::generate to generate benchmark data #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the price of always using the float16 special implementation regardless of data size, this allows us to get rid of the runtime type check.
This has to be done to avoid division by 0 that occurs with the other formula. Also use `static_cast<float16>` instead of `half_float` methods. This makes the implementation simpler and is good enough for simply returning numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements benchmark data generation with generator structs used with
std::generate. This clearly communicates the intent, making the code more readable than the raw loops used before.TODO:
float16support.Thoughts:
It would also be interesting to know whether the sparseness of the benchmark data (
float16case) affects results. There are even special FFT implementations for certain kinds of sparse data. With that in mind, it might even make sense to make benchmark data generators user-selectable at compile time. (Not now but as a possible new feature ;-))