Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes incorrect calculation of input length of rocfft r2c type #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hoptony
Copy link

@hoptony hoptony commented Aug 18, 2020

fixes 2D && 3D incorrect calculation of input length of rocfft real2complex type

@psteinb
Copy link
Contributor

psteinb commented Aug 31, 2020

@hoptony thanks for this contribution. Maybe @tdd11235813 or @zyzzyxdonta can comment too?

@zyzzyxdonta
Copy link
Contributor

I haven't used rocfft, sorry 🤷‍♂️

@zyzzyxdonta
Copy link
Contributor

I wanted to try it out but quickly failed because I can't get rocm and rocfft to build on my machine.

However, I noticed that gearshifft's build system is broken with CMake >= 3.17 because it uses a variable name starting with CMAKE (CMAKE_DEFAULT_BUILD_TYPE) and that name was introduced in CMake 3.17 to actually mean something. Maybe it could be renamed using the GEARSHIFFT_ prefix:

sed -i 's/CMAKE_DEFAULT_BUILD_TYPE/GEARSHIFFT_DEFAULT_BUILD_TYPE/g' cmake/init_build_type.cmake

@hoptony I noticed you commented out the old code and left it in. Maybe you could remove it. This would decrease the number of changed lines in your PR dramatically and the change would be more easily understandable by looking at the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants